Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real svg #13

Open
Agshin43 opened this issue Aug 30, 2016 · 8 comments
Open

Real svg #13

Agshin43 opened this issue Aug 30, 2016 · 8 comments
Labels

Comments

@Agshin43
Copy link

I cant create icon from custom svg. It says upload real svg. I downloaded from https://design.google.com/icons/ and it says same.

@Maddoc42
Copy link
Owner

Hey @Agshin43, thanks for the feedback. Could you please provide the following to narrow down the issue:

  • Icon file (the .svg file you are trying to use)
  • Browser + Version
  • Operating System

@Agshin43
Copy link
Author

Agshin43 commented Aug 30, 2016

Of course

Svg file
<svg fill="#000000" height="24" viewBox="0 0 24 24" width="24" xmlns="http://www.w3.org/2000/svg"> <path d="M12 17.27L18.18 21l-1.64-7.03L22 9.24l-7.19-.61L12 2 9.19 8.63 2 9.24l5.46 4.73L5.82 21 L12 17.27z"/> <path d="M0 0h24v24H0z" fill="none"/> </svg>

Browser
Safari
Version 9.1.1 (11601.6.17)

Operating System
OSX El Capitan
Version 10.11.15

@Maddoc42
Copy link
Owner

That's odd, the code at the point doesn't really do anything other than pass the file to the SVG library (paper.js), which returns undefined in case the file wasn't a valid SVG file (source).

Can you try a couple of more things?

  • Does selecting the "grade" icon (star) from the landing page work?
  • I have created a minimal paper.js example, does that display the star in your browser?
  • Does your icon work in Chrome?
  • Could you upload the exact file you were trying to process (actual file, not content)?

@Agshin43
Copy link
Author

Sory for bad english ) Ok. I can not upload here SVG file. SVG not supported for uploading here. Yes, it works when I pick grade (star) from your site (https://android-material-icon-generator.bitdroid.de/). But https://design.google.com/icons/#ic_grade not working on OSX - safari. Now I trying on Windows - Chrome it works properly.
Yes paper.js example shows star on windows - chrome. For now I am not able to check it OSX-safari.
Thank you. It is really very good tool for creating Material Design Icons.

@Maddoc42
Copy link
Owner

Thanks for testing that.

Once you have had the change to test the paper.js link on Safari please report back. In the meantime, GitHub issues seem to support .zip files. Could you upload the icon via that?

@Agshin43
Copy link
Author

Agshin43 commented Sep 2, 2016

Ok.
This is grade (star) icon.
ic_grade_black_24px-2.svg.zip.
Paper.js displays star icon but when drag and drop ic_grade_black_24px-2.svg to your page it says "Invalid SVG file" on OSX Safari. But on windows 10 chome it works properly

@Maddoc42
Copy link
Owner

Maddoc42 commented Sep 4, 2016

Thanks again for reporting back. So far my theory that there might be a problem with actually interpreting the SVG file does not seem to add up. Looking at the code, there might also be an issue with actually reading the file before passing it to paper.js.

I have deployed a version which contains some debug outputs. Could you try your icon again and report back with the console output?

@Maddoc42
Copy link
Owner

Hey @Agshin43, were you able to resolve your problem ❔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants