Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable changing of corner roundness #14

Open
benrap opened this issue Oct 22, 2016 · 1 comment
Open

Enable changing of corner roundness #14

benrap opened this issue Oct 22, 2016 · 1 comment

Comments

@benrap
Copy link

benrap commented Oct 22, 2016

How about an option to enable changing of corner roundness when choosing the square background?

@Maddoc42
Copy link
Owner

Yes, that would be great 👍 in fact, this could even replace the static option for square / round altogether and let the corner radius define how round the background is 🚀

Implementation should be "fairly" straight forward, roughly:

  • Add slider UI similar to shadow length etc.
  • Add listener to slider for reading corner radius. Values are between 0% and 100%, where 100% equals half the length of the background square which will create a perfect circle.
  • From the listener update the background radius, making sure to rerender the shadow after each update (see other sliders as an example).
  • Delete 'old' background UI option and remove associated code.

Am I missing something? 📝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants