Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set custom svg background shape #8

Open
AleksanderMielczarek opened this issue Apr 26, 2016 · 6 comments
Open

Allow to set custom svg background shape #8

AleksanderMielczarek opened this issue Apr 26, 2016 · 6 comments

Comments

@AleksanderMielczarek
Copy link

It would be nice to set two icons. One for foreground (as it is now) and second for background (in addition to current circle and square). What do you think about this idea?

@Maddoc42
Copy link
Owner

Great, I like it. Are you thinking about creating a pull request regarding this?

@AleksanderMielczarek
Copy link
Author

I'd love to contribute, but JS is not my thing.

@Maddoc42
Copy link
Owner

Thanks for the comment anyways :) I'll keep this open in case anyone feels like tackling this one, it shouldn't be too hard.

A couple of notes on how this could look like:

  • Menu 'Background shape' should have three check boxes: [ ] circle, [ ] square, [ ] custom
  • When 'custom' is selected have the icon picker appear in the menu on the left, similar to how the dev / beta banner colors appear

@Maddoc42
Copy link
Owner

Hey @AleksanderMielczarek. Even though this thread is a little old by now, would you mind elaborating what background shapes you would like to use? Are those shapes custom to your application or are you simply looking for more options, like star, heart, etc? 👍

@AleksanderMielczarek
Copy link
Author

Hi,

in this particular case I was looking for background in this shape (it has holes but it's ok, foreground for sure covers it). After all I used circle shape.

I don't know how hard would it be to implemented background chooser similar to foreground (circle, rectangle, Google icons and custom icon from local disc). Ideally with filled holes.

@Maddoc42
Copy link
Owner

Ok, makes sense, thanks for the explanation 👍

In theory not so super hard. It gets more complicated if that is combined with the score effect.

In any case, the issue stays :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants