Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include is_best in LOGS_SCHEMA #94

Open
ymerkli opened this issue Mar 24, 2021 · 1 comment
Open

Include is_best in LOGS_SCHEMA #94

ymerkli opened this issue Mar 24, 2021 · 1 comment

Comments

@ymerkli
Copy link

ymerkli commented Mar 24, 2021

I think it would be useful to include the is_best variable from train.train_model in the logs. Since log_info is passed to the epoch hook, the epoch hook function could then perform custom model checkpointing based on whether the current model is the best model so far.
For instance, I'm trying to checkpoint the classifier network itself (i.e. only AttackerModel.model, not the entire AttackerModel). This would be easier if an epoch hook had the information on whether the current model is best.

@andrewilyas
Copy link
Collaborator

This is a great idea, will make sure it's there in the next release, assuming it doesn't break anything :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants