Fixes the UK Met Office Datahub provider #3497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed connections to the new MetOffice data service.
|
Please base your work upon the develop branch, and not the master branch |
Have swapped out to the develop branch on the main project. Hopefully this is ok. If i need to re-fork my local copy to the develop rather than master as well then please let me know and i will re-do this. |
|
after you git clone, then git checkout develop and that branch started from develop. edit, test, fix changelog... then when submit the pr, this newbranch from your fork and select develop on MagicMirror |
LGTM |
|
Closing this request due to needing to change to the dev branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3384
Changed the UKMetOfficeDataHub provider to the new API structure as per the documentation.
API Base URL updated.
Header information amended to the correct key name.
API Secret no longer required so removed.
Changelog updated to reflect the change.