You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description: When the default weather module broadcasts its notification as WEATHER_UPDATED, the imperial units of current / forecasting temperatures (and speed of wind) is not respected. it is delivered as metric value.
Steps to Reproduce:
/* config/config.js*/units: "imperial",modules: [{module: "weather",position: "top_right",config: {weatherProvider: "openweathermap",type: "current",location: "New York",locationID: "5128581",//ID from http://bulk.openweathermap.org/sample/city.list.json.gz; unzip the gz file and find your cityapiKey: "..."}},
...
Expected Results:
Actual Results:
Additional Notes: I knew about this issue since very early MM, but nobody has reported this issue still yet. So I do.
The text was updated successfully, but these errors were encountered:
This PR resolve Issue number #3419 .
I have added the method `convertWeatherObjectToImperial()` which
converts the units of the `notificationPayload` to imperial if needed,
in order to pass the object in `sendNotification()`.
---------
Co-authored-by: veeck <[email protected]>
Platform: All (Mainly tested on MacOS, RPI 4)
Node Version: 20.8.0
MagicMirror² Version: 2.27
Description: When the default weather module broadcasts its notification as
WEATHER_UPDATED
, theimperial
units of current / forecasting temperatures (and speed of wind) is not respected. it is delivered asmetric
value.Steps to Reproduce:
Expected Results:
Actual Results:
Additional Notes: I knew about this issue since very early MM, but nobody has reported this issue still yet. So I do.
The text was updated successfully, but these errors were encountered: