Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newsfeed enclosured picture feature #3447

Closed
bugsounet opened this issue May 10, 2024 · 7 comments
Closed

newsfeed enclosured picture feature #3447

bugsounet opened this issue May 10, 2024 · 7 comments

Comments

@bugsounet
Copy link
Contributor

bugsounet commented May 10, 2024

Hi, i plan to add to newsfeed default module an enclosured picture of the item displayed.

What do you think about this feature?

@sdetweil
Copy link
Collaborator

more info..
enclosure picture of the item displayed

doesn't mean anything to me..

give examples..
does this mean it can't fit on the bottom_center anymore (too tall?)

@bugsounet
Copy link
Contributor Author

The picture like this (example of one of my modules):

many feed have an enclosured picture related of article why not display it ?

@bugsounet bugsounet changed the title newsfeed enclosure feature newsfeed enclosured picture feature May 12, 2024
@sdetweil
Copy link
Collaborator

ok, got it now.

I personally don't think the base should take on this kind of technical debt. That's what the 3rd party ecosystem is for. we give examples of what can be done in a functional way, we don't do every solution.

@bugsounet
Copy link
Contributor Author

ok, it's just a proposal ;)

@rejas
Copy link
Collaborator

rejas commented May 13, 2024

I wouldnt close it so fast, cause I like the idea. We always add new functionality to our code modules, so why not this? Maybe disable it per default, so the "slick" look is preserved.

@bugsounet
Copy link
Contributor Author

@rejas: Ok, i will see

Copy link

github-actions bot commented Oct 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants