-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GeoInterface 1 support #117
Comments
Perfect, that sounds good! Will keep an eye out for GeoJSON release (is it better to move to GeoJSONTables?) |
You mean instead of a breaking GeoJSON release, to register GeoJSONTables? I think since GeoJSON is so tied to the old GeoInterface, and all current GeoJSON features will be present in GeoJSONTables, and the maintainers will be the same, there is not much point in having two GeoJSON packages side by side. |
Makes sense...I meant more on the GeoMakie side, based purely on parse speed. |
copied from #115 (comment)
We can work on the GeoInterface integration when JuliaGeometry/GeometryBasics.jl#175 and JuliaGeo/GeoJSON.jl#36 are ready, since this package relies on both packages. Right now GeoInterface 1 cannot be used with this package because GeoJSON.jl is preventing that.
These conversions won't be needed anymore:
https://github.com/JuliaPlots/GeoMakie.jl/blob/ea3e71baa108a90f924172bf59de3519380bd769/src/conversions.jl#L4-L53
And these assets can be updated:
https://github.com/JuliaPlots/GeoMakie.jl/blob/ea3e71baa108a90f924172bf59de3519380bd769/src/data.jl#L11-L24
The text was updated successfully, but these errors were encountered: