Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoInterface 1 support #117

Closed
visr opened this issue Jun 15, 2022 · 3 comments · Fixed by #123
Closed

GeoInterface 1 support #117

visr opened this issue Jun 15, 2022 · 3 comments · Fixed by #123

Comments

@visr
Copy link
Collaborator

visr commented Jun 15, 2022

copied from #115 (comment)

We can work on the GeoInterface integration when JuliaGeometry/GeometryBasics.jl#175 and JuliaGeo/GeoJSON.jl#36 are ready, since this package relies on both packages. Right now GeoInterface 1 cannot be used with this package because GeoJSON.jl is preventing that.

These conversions won't be needed anymore:

https://github.com/JuliaPlots/GeoMakie.jl/blob/ea3e71baa108a90f924172bf59de3519380bd769/src/conversions.jl#L4-L53

And these assets can be updated:

https://github.com/JuliaPlots/GeoMakie.jl/blob/ea3e71baa108a90f924172bf59de3519380bd769/src/data.jl#L11-L24

@asinghvi17
Copy link
Member

Perfect, that sounds good! Will keep an eye out for GeoJSON release (is it better to move to GeoJSONTables?)

@visr
Copy link
Collaborator Author

visr commented Jun 15, 2022

You mean instead of a breaking GeoJSON release, to register GeoJSONTables? I think since GeoJSON is so tied to the old GeoInterface, and all current GeoJSON features will be present in GeoJSONTables, and the maintainers will be the same, there is not much point in having two GeoJSON packages side by side.

@asinghvi17
Copy link
Member

Makes sense...I meant more on the GeoMakie side, based purely on parse speed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants