Full support of recipes with MakieCore (lift, legendelements, ATTRIBUTES...)

[BambOoxX]

Unless I am mistaken, MakieCore is aimed at being the lightweight dependency package developpers should rely on when implementing specific recipes for their packages. Something alike RecipesBase for Plots.jl.

While trying to switch from Makie to MakieCore as a dependency, I got an error showing that @lift is not defined in MakieCore, making use of observables surprinsingly impossible when relying on MakieCore.

A quick and dirty idefined(MakieCore,lift) returns a false, while the same on Makie is true.

Is there something I'm missing here ?

I'm on julia 1.8.0 using Makie v0.17.13 and MakieCore v0.4.0

[SimonDanisch]

Well, since it's lightweight, lots has been left out..Although I guess @lift could be added...

[BambOoxX]

@SimonDanisch BTW, I just checked the code in MakieCore and it seems that some comments refer to a solution involving lift e.g. here

Makie.jl/MakieCore/src/attributes.jl

Lines 110 to 122 in c373d3f

	function Base.setindex!(x::Attributes, value::Observable, key::Symbol)
	if haskey(x, key)
	# error("You're trying to update an attribute Observable with a new Observable. This is not supported right now.
	# You can do this manually like this:
	# lift(val-> attributes[$key] = val, Observable::$(typeof(value)))
	# ")
	return x.attributes[key] = node_any(value)
	else
	#TODO make this error. Attributes should be sort of immutable
	return x.attributes[key] = node_any(value)
	end
	return x
	end

Does this mean that lift alone, not the macro, should work ?

[BambOoxX]

@SimonDanisch While testing things around recipes, it seems that the ATTRIBUTES string lies in Makie, as well as legendelements. To me it feels like both could be good additions to MakieCore, but I may have missed equivalent stuff in there.
What is your opinion on this ?

[BambOoxX]

@SimonDanisch I just checked the code a bit for lift. Do you think solving this would just require to move the src/interaction to MakieCore and reexport this in Makie ?

[BambOoxX]

Light Bump ! 👍

[SimonDanisch]

We can definitely move const lift = map to MakieCore!
I personally try to avoid @lift and now that we have lift(f, scene/plot, observables...) to bind the observable life time to a scene/plot object, which @lift doesn't support, I've been removing @lift from quite a few places.
So, I'm leaning against moving it to MakieCore ;)

[BambOoxX]

@SimonDanisch I think we can afford the const lift=map indeed ! What about ATTRIBUTES which are super handy for recipes (so MakieCore scope) and legendelements (since it feels weird to be able to write a recipe but not its legend, though its seems a more complicated modification) ?

[asinghvi17]

ATTRIBUTES pulls in DocStringExtensions.jl, which we may not want.

[BambOoxX]

Sure, if it is pulling another dependency, that is not good, although basic recipes like arrows use ATTRIBUTES. So if this is not the proper way to make the help section for a recipe we are either missing a piece of code here or it should be in MakieCore shouldn't it ?

[BambOoxX]

We can definitely move const lift = map to MakieCore! I personally try to avoid @lift and now that we have lift(f, scene/plot, observables...) to bind the observable life time to a scene/plot object, which @lift doesn't support, I've been removing @lift from quite a few places. So, I'm leaning against moving it to MakieCore ;)

@SimonDanisch Do you have an example of this in the documentation ? I could not find one

[BambOoxX]

Hi @SimonDanisch I read somewhere on the discourse I think, that you are close to updating things regarding recipes. Is there any news regarding this issue ?

[SimonDanisch]

Well, the new plotspec API is one part of the puzzle, another one will be the axis converts in #442 .
If that's all done I hope to clean up the missing bits and finally document everything nicely!