-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcode Makie's default fonts to avoid findfont latency #2528
Comments
This seems like the right solution. We're starting to write up TTFX blog posts etc. that will include many benchmarks, and it would be nice to be able to include Makie. Fixing this issue appears to be Makie's ticket-to-entry (I will exclude it from discussion otherwise), as on my system Makie's font selection accounts for almost all of the TTFP (compilation is just ~1%). Plots has a similar (though much less serious) issue, xref jheinen/GR.jl#505. |
Previously I had a latency for |
On my computer and Julia master, this brought down the |
It's crazy that this was going on for so long, goes to show again that the systems that the devs run matter a lot. |
It seems that font search can account for long loading latency if a user has a lot of font files JuliaLang/julia#47184 (comment)
There were ideas to solve this on the FreeTypeAbstraction level by caching the list of fonts found on the system, for example in this issue: JuliaGraphics/FreeTypeAbstraction.jl#67
I think it might make sense to just add the names of Makie's default fonts as they are specified in the theme to
Makie.to_font
, so thatfindfont
is not even run for those names. Sort of like:I think this would be the easiest to do because it doesn't need a caching mechanism to alleviate the latency issue (we can still add better caching to FreeTypeAbstraction later if desired).
The text was updated successfully, but these errors were encountered: