Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitrary topoplot types #47

Open
asinghvi17 opened this issue Apr 23, 2024 · 2 comments
Open

Arbitrary topoplot types #47

asinghvi17 opened this issue Apr 23, 2024 · 2 comments

Comments

@asinghvi17
Copy link
Member

Would it make sense to add a plottype kwarg to TopoPlot, which would allow any HeatmapLike plot to be used in place of contourf? I would love to use surface or even contour, for example.

@behinger
Copy link
Collaborator

maybe there is a good way. We already have an ugly if / else solution for "mesh" here:

if p.interpolation[] isa DelaunayMesh

So if this can be generalized, that would be great anyway.

But then I guess only replacing the surface command with a plottype would be much easier and more "surgical". I don't see the downside

@palday
Copy link
Collaborator

palday commented May 16, 2024

I don't have an objection to this, though I would do something more like plotfnc=heatmap! as a default attribute in the recipe. Then you just change

heatmap!(p, xg, yg, data, colormap=p.colormap, colorrange=colorrange, interpolate=true)

to use plotfnc instead of heatmap!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants