Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eeg_topoplot: labels need to be specified twice #39

Open
behinger opened this issue Jan 18, 2024 · 0 comments · May be fixed by #56, #57 or #58
Open

eeg_topoplot: labels need to be specified twice #39

behinger opened this issue Jan 18, 2024 · 0 comments · May be fixed by #56, #57 or #58

Comments

@behinger
Copy link
Collaborator

labels = ["cz", "fp1", "fp2", "fz"]
TopoPlots.eeg_topoplot(1:length(labels),labels;                        label_text = true) # doesnt work
TopoPlots.eeg_topoplot(1:length(labels),labels; labels=labels, label_text = true) # works

is necessary. The reason most likely is that in the recipe label is used as this "named"-input

@recipe(EEG_TopoPlot, data, labels) do scene

later it is referenced in the plot! function via

tplot = topoplot!(plot, Attributes(plot), plot.data, positions; labels=plot.labels)

not sure why the first case, labels seem to not be picked up correctly. Maybe a hint: Attributes(plot) is used, and in there, labels = nothing. Even though plot.labels is correctly showing the Array. - I dont know enough to understand this

maybe @SimonDanisch any insights?

(This was not the case in topoplots 1.3, with pre 0.20 makie (didnt test all iterations))

pinging @marcpabst for pushing me to this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant