upgrade to template 10-05 locations #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for eeg-topoplot only
T4 is now T8
T5 is now P7
T6 is now P8
according to the MCN system
|
I did one shortcut I have to fix: I renamed 4 10-20 channels (T3,T4,T5,T6) to their 10-05 counterpart; but I think I should rather just repeat the channels in the dictionary after loading the data |
Yes, we can have 'duplicates' for alternate names. |
palday
reviewed
Sep 30, 2024
docs/src/topo_series.jl
Outdated
There was a problem hiding this comment.
drop this file from this PR 😄
palday
reviewed
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded the 10-20 to the superset 10-05. Be warned though, the 10-20 we provided before were taken from MNE. But MNE had a (for visualization) suboptimal default of some 10-20 spherical ("perfect") locations warped to the fsaverage brain. That is probably good for source localisation, but not good for visualization (e.g. we noticed Cz is not at 0/0).
I also made a breaking change to put enlarge = 1 instead of enlarge = 1.2 - it always gave me a bit weird results and I think 1.0 is the natural factor. I dont know why in topoplot enlarge is by default 1.2?