Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Prefer Romaji Series Title Language Setting [series_title_language] does not appear to do anything. [v1.0.4] #198

Open
Middlepepper opened this issue Dec 31, 2023 · 9 comments
Labels
help wanted Extra attention is needed

Comments

@Middlepepper
Copy link

Middlepepper commented Dec 31, 2023

Describe the bug
When using the Prefer Romaji Series Title Language setting under Anilist, It should switch the Series name and LocalisedSeries values as series_title_language Is set to False. This does not happen with "I Think I'll Cheat to Become a Spellsword in Another World" as a example.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Settings'
  2. Click on 'Anilist'
  3. Click on 'Prefer Romaji Series Title Language'
  4. Click on 'Save'
  5. Close and 'Reopen Manage Manager'
  6. Click on 'Filename Fill'
  7. Click on 'Fetch Online'
  8. See error

Expected behavior
The Series Title and Localized title Should be switched as When Prefer Romaji Series Title Language box is ticked/unticked this does not change at all.

Screenshots
If applicable, add screenshots to help explain your problem.
When Not Ticked
image
Output when When Not Ticked
image
When Ticked
image
When Ticked
image
I have closed and reopened Manga Manager v1.0.4 for this test.

Additional context
When Prefer Romaji Series Title Language box is ticked I have the same output as above. So there no change at all When Prefer Romaji Series Title Language box is ticked or unticked.

@Middlepepper Middlepepper changed the title [Bug] series_title_language config does not appear to do anything. [Bug] series_title_language config does not appear to do anything. [v1.0.4] Dec 31, 2023
@Middlepepper Middlepepper changed the title [Bug] series_title_language config does not appear to do anything. [v1.0.4] [BUG] Prefer Romaji Series Title Language Setting [series_title_language] does not appear to do anything. [v1.0.4] Dec 31, 2023
@ThePromidius
Copy link
Member

Either i didn't fully understand your issue or it's working as expected on my side.
I checked that the settings does get saved correctly. So after enabling Prefer Romaji Series Title it became True in the settings.

I tried with the series you tried, I Think I'll Cheat to Become a Spellsword in Another World and it successfully loaded Isekai Tenishita node Cheat wo Ikashite Mahou Kenshi Yaru Koto ni Suru as series and I Think I'll Cheat to Become a Spellsword in Another World as localized series.

@ThePromidius ThePromidius added the help wanted Extra attention is needed label Jan 8, 2024
@majora2007
Copy link
Contributor

I think the issue Promidius is that when it's explicitly set to False, the Series should be I Think I'll Cheat to Become a Spellsword in Another World and the LocalizedSeries should be Isekai Tenishita node Cheat wo Ikashite Mahou Kenshi Yaru Koto ni Suru. That is what Prefer Romanji = False implies (Prefer English).

@ThePromidius
Copy link
Member

Yeah that's correct and it's the current and expected behaviour

@Middlepepper
Copy link
Author

Middlepepper commented Jan 10, 2024

Hi All, Sorry if it was a bit confusion. I have added some screenshot to the OP to clarify the issues.

Error: The Prefer Romaji Series Title Language setting under Anilist does not change anything. There is no way for the English title to appear in the Series Textbox when it is ticked or not ticked.

As Majora said When Prefer Romaji Series Title Language box is not ticked (which I assumed mean Romanji = False in the config from the tooltip) the Series should be I Think I'll Cheat to Become a Spellsword in Another World and the LocalizedSeries should be Isekai Tenishita node Cheat wo Ikashite Mahou Kenshi Yaru Koto ni Suru

Per the screenshot below the Prefer Romaji Series Title Language is unticked and the tooltip says this should provide English as the Series name and Romanji and the LocalizedSeries Name.
image

I get the following output which is Romaji in the Series field and english in the LocalizedSeries which is an error right?

image

So in the example it is backward from what I see in the tooltip. The correct output should be

Series: I’m the Evil Lord of an Intergalactic Empire!
LocalizedSeries: Ore wa Seikan Kokka no Akutoku Ryoushu! 

Even When Prefer Romaji Series Title Language box is ticked I have the same output as above. So there no change at all When Prefer Romaji Series Title Language box is ticked or unticked.

image
image
I have closed and reopened Manga Manager v1.0.4 for this test.

@Middlepepper
Copy link
Author

Ok some additional context it looks like I get a error in the logs when trying to change Prefer Romaji Series Title Language

2024-01-10 14:20:29,542 - root - ERROR - Section or Key did not exist in settings: Main.clean_ui_on_drag_drop

This might be the cause of the issue. I'm going to delete my setting folder and re-download MangaManager.

@Middlepepper
Copy link
Author

Middlepepper commented Jan 10, 2024

Error in the Logs from a clean install, Look like the the setting option triggered the error I tested and it keeps repeating the line

root - ERROR - Section or Key did not exist in settings: Main.clean_ui_on_drag_drop

When Prefer Romaji Series Title Language is changed the error appears.

image

@ThePromidius
Copy link
Member

This was handled in 9c21743 i believe. But checking it seems it was already in main 🤔 so a bit confused now. I haven't had any issues so wait untill #200 is merged and recheck

@shinji257
Copy link

shinji257 commented Apr 20, 2024

I'm able to reproduce this issue. I was using 1.0.4 and when I switched to the latest nightly (2/27/2024) it still does it. Figured I might show this in a video. I first show the normal behavior and then I show toggling the option and what happens after. I also process it the second round and show the resulting ComicInfo also has the wrong info.

bandicam.2024-04-20.12-48-04-862.mp4

Screenshot for quicker reference showing build in use:
image

@Middlepepper
Copy link
Author

I'm able to reproduce this issue. I was using 1.0.4 and when I switched to the latest nightly (2/27/2024) it still does it. Figured I might show this in a video.

Thanks for posting a video. I didn't even think you could embed them in GitHub!

@hmsmart hmsmart mentioned this issue May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants