Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py get_version fails on Python 3.13 #112

Closed
stefanor opened this issue Sep 12, 2024 · 1 comment · Fixed by #111
Closed

setup.py get_version fails on Python 3.13 #112

stefanor opened this issue Sep 12, 2024 · 1 comment · Fixed by #111

Comments

@stefanor
Copy link

$ python3.13
Python 3.13.0rc2 (main, Sep  7 2024, 08:52:38) [GCC 14.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> def get_version():
...     version_file = "manimpango/_version.py"
...     with open(version_file) as f:
...         exec(compile(f.read(), version_file, "exec"))
...     return locals()["__version__"]
... 
>>> get_version()
Traceback (most recent call last):
  File "<python-input-1>", line 1, in <module>
    get_version()
    ~~~~~~~~~~~^^
  File "<python-input-0>", line 5, in get_version
    return locals()["__version__"]
           ~~~~~~~~^^^^^^^^^^^^^^^
KeyError: '__version__'
>>> 

Could be due to: https://docs.python.org/3.13/whatsnew/3.13.html#defined-mutation-semantics-for-locals

@naveen521kk
Copy link
Member

Thanks for reporting! I've already fixed this issue it in #111. That PR requires some more work, so I'll close this issue when merging it and release a new version.

@naveen521kk naveen521kk linked a pull request Sep 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants