You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The implementation of get_quadratic_approximation_of_cubic caused some headache: when I tried to replace the current implementation of bezier, a test using get_quadratic_approximation_of_cubic started to fail because the points used in that function are not just 1d-numpy arrays as usual, but instead 2d ones. If someone wants to take a stab at fixing this, please go ahead -- then this classic_bezier function could also just be removed.
PR #3829 had the side effect of removing calls to bezier inside get_quadratic_approximation_of_cubic. Thus, in the future, if someone wants to continue with PR #2421, they should now be able to rewrite the bezier function without having to move the old code into classic_bezier.
The implementation of
get_quadratic_approximation_of_cubic
caused some headache: when I tried to replace the current implementation ofbezier
, a test usingget_quadratic_approximation_of_cubic
started to fail because the points used in that function are not just 1d-numpy arrays as usual, but instead 2d ones. If someone wants to take a stab at fixing this, please go ahead -- then thisclassic_bezier
function could also just be removed.Originally posted by @behackl in #2421 (comment)
The text was updated successfully, but these errors were encountered: