Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_quadratic_approximation_of_cubic should also use bezier and classic_bezier should be removed #2427

Closed
behackl opened this issue Jan 6, 2022 · 1 comment · Fixed by #3829

Comments

@behackl
Copy link
Member

behackl commented Jan 6, 2022

The implementation of get_quadratic_approximation_of_cubic caused some headache: when I tried to replace the current implementation of bezier, a test using get_quadratic_approximation_of_cubic started to fail because the points used in that function are not just 1d-numpy arrays as usual, but instead 2d ones. If someone wants to take a stab at fixing this, please go ahead -- then this classic_bezier function could also just be removed.

Originally posted by @behackl in #2421 (comment)

@chopan050
Copy link
Contributor

chopan050 commented Dec 6, 2024

PR #3829 had the side effect of removing calls to bezier inside get_quadratic_approximation_of_cubic. Thus, in the future, if someone wants to continue with PR #2421, they should now be able to rewrite the bezier function without having to move the old code into classic_bezier.

I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
2 participants