Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epub highlights #3

Open
JideGuru opened this issue Apr 18, 2023 · 9 comments
Open

Epub highlights #3

JideGuru opened this issue Apr 18, 2023 · 9 comments

Comments

@JideGuru
Copy link

@jmgeffroy can you give me any pointers on how highlights can be achieved with this package?

@jmgeffroy
Copy link
Collaborator

Hello @JideGuru! First, sorry for the current lack of support. I'm completely overwhelmed with other projects. Can you test the Iridium Demo App and test the highlights? It's already implemented.

You can find the code (or part of it) here.

Can you confirm it matches what you are looking for ? Since I definitely cannot currently work more on Iridium but love this project, I'd be very happy to see you working on it ;-)
I see a bug: the highlight popup menu that appears after selecting text remains on the screen if closing the book. So it requires some debugging, but most of the work is done.

I'll stay tuned, hoping JideGuru can help :-D

@JideGuru
Copy link
Author

Works well. Thanks @jmgeffroy

@JideGuru JideGuru reopened this May 14, 2023
@JideGuru
Copy link
Author

Hi @jmgeffroy
The highlight doesn't work on ios.
Do you have any tips on this?
and is this related to Mantano/iridium#59?

@jmgeffroy
Copy link
Collaborator

Hi @JideGuru, I'm afraid you're right. This means I have to dedicate a few hours to it. I'll get back to you hopefully shortly...

@JideGuru
Copy link
Author

JideGuru commented May 16, 2023

Okay, thanks @jmgeffroy . If you can't find the time to fix it you can probably point to the direction I can take to fix it or maybe the files that i can work on to fix this issue

@jmgeffroy
Copy link
Collaborator

Thank you for your proposal, that would definitely be great. I'll send you tomorrow some clues (I can't right now).

@JideGuru
Copy link
Author

Sounds good to me. There are some other issues that I've encountered. I'll open separate tickets for them soon

@JideGuru
Copy link
Author

@jmgeffroy Did you get some time to look into the problem or can you give me some tips about it? Thanks

@westernbuptboy
Copy link

@jmgeffroy Did you get some time to look into the problem or can you give me some tips about it? Thanks

Dear Developer

I have also encountered the same problem. Currently, there is no problem with the highlight pop-up on Android, and only the system's text selection pop-up can pop up on iOS. Highlights or notes are invalid. Have you resolved this issue now? Can you share your solution if it is resolved? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants