-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
psuedoBulkDGE #80
Comments
Should be there. Make sure you're using a reasonably version of the package - see install instruction here. |
is it possible that there is a bug in pseudoBulkDGE? I get the following error when using pseudobulkdge `samples <- colData(sce) %>% design <- model.matrix(~ 0 + health, data = samples) %>% contrast <- limma::makeContrasts(healthad - healthhc, levels = design) dea <- pseudoBulkDGE(se, sample = se$sample, label = se$celltype,
I cannot see where the function assigns the appropriate value to lfc.null my sessionInfo() `R version 4.0.3 (2020-10-10) Matrix products: default locale: attached base packages: other attached packages: loaded via a namespace (and not attached): |
There is a bug, but also you should have gotten a deprecation warning along the lines of:
Matrices are deprecated because it was really painful to figure out how the rows of the matrix matched up to the subset of data for a particular cell type if that cell type wasn't present in all samples. Then we would have to remove rows of the matrix, and the result might not be of full rank... very tricky. The solution is just to pass: dea <- pseudoBulkDGE(se, sample = se$sample, label = se$celltype,
condition = se$health, design = ~0+ health,
contrast = "healthad - healthhc")` |
wow...many thanks you made my day :-D It worked 👍 However, I somehow realized that my colleague with the same code (only difference is the adjustment you shared here) has slightly different DGE lists. Did you change anything in the way you do the statistics when comparing version 1.16 to 1.18 or would you expect the same DGE lists? |
Hm... nothing on my end, at least not from memory. Something may have changed in edgeR itself. Might be worth installing 1.18.4 from the Edit: Hm. There is a difference. Wonder why that happens. Edit 2: Oh, it's another bug in the old implementation, related to how |
Hello,
Is this function no longer available with scran?
Best,
Emily
The text was updated successfully, but these errors were encountered: