Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] #27539 Filament sensor message is missing in M119 report #27576

Open
1 task done
rondlh opened this issue Dec 9, 2024 · 0 comments · May be fixed by #27596
Open
1 task done

[BUG] #27539 Filament sensor message is missing in M119 report #27576

rondlh opened this issue Dec 9, 2024 · 0 comments · May be fixed by #27596

Comments

@rondlh
Copy link
Contributor

rondlh commented Dec 9, 2024

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

#27539 Breaks the filament status message, the text "filament" is missing:

Reporting endstop status
x_min: open
y_min: open
z_probe: TRIGGERED
: TRIGGERED

endstops.cpp

OLD: print_es_state(READ(FIL_RUNOUT1_PIN) != FIL_RUNOUT1_STATE, F(STR_FILAMENT));
NEW: print_es_state(!FILAMENT_IS_OUT());

SHOULD BE: print_es_state(!FILAMENT_IS_OUT(), F(STR_FILAMENT));

Bug Timeline

#27539

Expected behavior

Filament reported as before

Actual behavior

"filament" text is missing from M119 report

Steps to Reproduce

Run M119

Version of Marlin Firmware

Latest bugfix with #27539

Printer model

No response

Electronics

Custom

LCD/Controller

No response

Other add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Not relevant but here it is:
Configuration_adv.zip

@rondlh rondlh changed the title [BUG] #27539 Filament sensor message fix [BUG] #27539 Filament sensor message is missing in M119 report Dec 9, 2024
@thisiskeithb thisiskeithb added this to the Version 2.1.3 milestone Dec 9, 2024
GMagician added a commit to GMagician/Marlin that referenced this issue Dec 17, 2024
@GMagician GMagician linked a pull request Dec 17, 2024 that will close this issue
@thisiskeithb thisiskeithb linked a pull request Dec 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants