Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Enhancement]: Unify and Improve @DateFormatting #16

Open
4 tasks
MasterJ93 opened this issue May 13, 2024 · 0 comments
Open
4 tasks

[Feature Enhancement]: Unify and Improve @DateFormatting #16

MasterJ93 opened this issue May 13, 2024 · 0 comments
Labels
enhancement An enhancement to an existing feature. good first issue Good for newcomers

Comments

@MasterJ93
Copy link
Owner

Summary

Create a solution where the @DateFormatting property wrapper is able to handle all of the requirements without the need to create custom implementations.

Pain points

At this time, there are two property wrappers: @DateFormatting and DateFormattingOptional. While their current implementations work, there are a couple of issues:

  • Having one for Date and another for Date? can be a little bit confusing and can possibly lead to situations where bugs can occur.
  • The initializers currently have an unconventional way of being initialized, where the property must begin with an underscore before the name of the variable.
  • The decoding and encoding methods must be implemented.

A solution is needed to fix the latter two, while the first issue can be solved by merging @DateFormatting and @DateFormattingOptional into one, unified @DateFormatting property wrapper.

Considered Alternatives

No response

Is this a breaking change?

No

Library Examples

No response

Additional Context

The tasks include:

  • Add the @DateFormattingOptional-related implementations into @DateFormatting.
  • Tweak the code so the standard initializer is no longer needed to be initialized.
  • Tweak the code so that creating a customized decoding method is no longer required.
  • Tweak the code so that creating a customized encoding method is no longer required.
@MasterJ93 MasterJ93 added new feature New feature or request good first issue Good for newcomers enhancement An enhancement to an existing feature. and removed new feature New feature or request labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to an existing feature. good first issue Good for newcomers
Projects
Status: In Progress
Development

No branches or pull requests

1 participant