Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing for failed cases #30

Open
neilstuartcraig opened this issue May 31, 2016 · 1 comment
Open

Testing for failed cases #30

neilstuartcraig opened this issue May 31, 2016 · 1 comment

Comments

@neilstuartcraig
Copy link
Contributor

Hi again
After doing the work for createBucket, the simple version, I noticed that there are at least some tests which are only testing for the correct, direct use-case. I think it'd be prudent to verify correct handling for e.g. incorrect method arguments. I realise that you don't want to emulate the AWS API entirely but I think some handling of incorrect args etc. would be very worthwhile.

Any thoughts?

Cheers

@MathieuLoutre
Copy link
Owner

I noticed you were quite thorough with the argument checking in the createBucket method. It's obviously a lot better to do that I think, although I suspect most people only use this at the moment to test /mock positive cases and not as an offline version of AWS that you can develop against. I'm afraid that extensive arg handling might get in the way, but if other people feel the need for it, it's something that should be included. Does that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants