Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getSignedUrl doesn't call callback for putObject operation #75

Open
ScottyMJacobson opened this issue Dec 14, 2020 · 1 comment
Open

Comments

@ScottyMJacobson
Copy link

getObject works as expected, but putObject looks like it's still stubbed out without a fake implementation (one that would call the callback or work as a promisified)

case 'putObject':

I think the solution would be just to add callback(null, url) on like 625? Would need to look more at the spec for getSignedUrl to make sure the dummy url would work for both

@muhammadfaizan
Copy link

@ScottyMJacobson same issue, guess we need to send a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants