Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Images to the bottom of Now Showing for resolution, sound format, and aspect ratio #74

Open
titelies opened this issue Mar 26, 2021 · 17 comments

Comments

@titelies
Copy link

titelies commented Mar 26, 2021

Hoping that at some point PMPD can collect metadata info from Plex that would display resolution, sound formats, and aspect ratio as seen in this example: https://i.redd.it/cb14liq7fxj41.jpg possibly with the help of https://imagemagick.org/index.php

@ZeroCoolGOS
Copy link

Working on it.

I just need to find the assets.

Do you have a link to the assets that we can use?

@ZeroCoolGOS
Copy link

And... who's system is that? :)

I would like to check out others systems to get ideas.

@titelies titelies changed the title Images to the bottom of Now Showing for resolution, sound format, and aspect ratio Enhancement: Images to the bottom of Now Showing for resolution, sound format, and aspect ratio Mar 26, 2021
ZeroCoolGOS added a commit to ZeroCoolGOS/Plex-Movie-Poster-Display that referenced this issue Mar 30, 2021
Enhancement: Images to the bottom of Now Showing for resolution, sound format, and aspect ratio (Issue MattsShack#74)
- Create GIMP template file for all icons for 'Presented' mode
- Add support for resolution display
- Add support for rating display
- TODO:
    - Add support for sound format
    - Add support for aspect ratio
    - Add support for changing 'font color' for 'PRESENTED IN' text
    - Add icons for 720p & 1080p (explicit)
- BUG(s):
    - If playing a lower quality video the 'current' video resolution is not displayed.
@titelies
Copy link
Author

Superb work @ZeroCoolGOS I don't know if it needs the "Presented In" text, displays so small both on my laptop and TV, font size doesn't seem to effect the text. The logos should be sufficient and probably could be larger so that the text is legible... WOW dude! My sample images:
https://i.imgur.com/L5qZ4M9.jpg
https://i.imgur.com/RYocbej.jpg

@ZeroCoolGOS
Copy link

Yes. The font size does not control that text (yet).

I was not sure if we wanted the "Presented In". I was just following the example provided earlier.

I may add an option to change or disable the text.

The images are a bit small on display as they are scaled at 20% so I can increase them easily.

I still have some more metadata to get but some info has been a bit difficult to read.

If there is any other data you want let me know.

I am still working on radio and the audio info. Also I have a few glitches to address.

I am also thinking of changing the color combo of the ratings as the black boarder on a black background kinda makes it look even smaller then it is.

@ZeroCoolGOS
Copy link

That is an idea. I had thought of it. But did not have this link.

I custom made these ones so that it would have a more consistent look, feel and size. Including support for TV show ratings.

@titelies
Copy link
Author

Completely understand and appreciate all you've done. Was hoping to cut some work for you but I get it... Consistency and similar size should make it easier for other adjustments.

@ZeroCoolGOS
Copy link

I have also included a template file so I can pump out updated and new icons fast 😄

ZeroCoolGOS added a commit to ZeroCoolGOS/Plex-Movie-Poster-Display that referenced this issue Apr 1, 2021
Enhancement: Images to the bottom of Now Showing for resolution, sound format, and aspect ratio (Issue MattsShack#74)
- Update icons to be better color coded and easier to read
- Update to support audio information
- Update CSS to support size of icons depending on screen orientation
- Add support for font size 'Presented In' to use bottom font.
- Add iconChangeID code to icon links to force a non-cache image so that when updating to newer versions of the project the new icons will be displayed.
- TODO:
    - Update TV Ratings icons to better match film icons
    - Look at spacing between icons

Enhancement: Full Path Logging (Issue MattsShack#75)
- Update logging system to provide full URL to media XML

Enhancement: Plex Function Isolation (Issue MattsShack#64)
- Isolate PLEX read from using 'clients' variable and converted to PLEX object.  Full conversion still in progress.
- Clean up duplicated variables for 'logName' to use as part of PLEX object.
- Move away from reading media session information xml to direct media information for much richer metadata.  Media session information still required to get direct media library ID for direct read.
@titelies
Copy link
Author

titelies commented Apr 1, 2021

@ZeroCoolGOS I am able to adjust "PRESENTED IN" Font Size with new 11.5 update, nice work on the audio icons!!! This time the icons appear to be too large and I saw from your update info that you are still looking into the spacing issue. Hope this is helpful info to you: https://i.imgur.com/fZVGpuI.jpg

@ZeroCoolGOS
Copy link

@titelies
Cool.

I will adjust smaller. I will even look at the idea of giving control of the size to the users in the future.

If you want you can adjust it yourself in the DisplaySettings.css file.

As for the spacing I had a few more options that had been coded but not working yet so have been disabled and the way the images where spaced was not even so I have them up against each other. I am not sure if a single space is sufficient. I will be doing a bit of playing around.

How is the size to orientation?

The icons should be smaller in landscape.

@titelies
Copy link
Author

titelies commented Apr 1, 2021

@ZeroCoolGOS I couldn't find a DisplaySettings.css file, did you possibly mean the DisplayStyle.css file, to change the width percentage:
@media screen and (orientation: portrait) {
.showMetadata img {
width: 40%;

I checked it on my laptop in landscape and the icons look like this: https://i.imgur.com/UShQPve.png

@ZeroCoolGOS
Copy link

Yes. I forgot what I had named it. Lol

@titelies
Copy link
Author

titelies commented Apr 1, 2021

@ZeroCoolGOS Tried changing the width percentages for both the landscape and portrait for the .showMetadata img but it had no effect on my TV display in portrait or my laptop in landscape.

FYI: It seems like PMPD displays the icons for the default audio and video metadata. It doesn't actually display the correct audio of what is currently selected and playing on the client, I have the movie playing with 5.1 audio but it's showing 2.0 Stereo. Since, I have multiple audio files for everyone of my movies, it seems to choose the first audio file from the list and displays that icon. Same result applies to Video, if 720p is currently selected and playing on the client, PMPD displays the 1080p icon.

@ZeroCoolGOS
Copy link

@ZeroCoolGOS Tried changing the width percentages for both the landscape and portrait for the .showMetadata img but it had no effect on my TV display in portrait or my laptop in landscape.

FYI: It seems like PMPD displays the icons for the default audio and video metadata. It doesn't actually display the correct audio of what is currently selected and playing on the client, I have the movie playing with 5.1 audio but it's showing 2.0 Stereo. Since, I have multiple audio files for everyone of my movies, it seems to choose the first audio file from the list and displays that icon. Same result applies to Video, if 720p is currently selected and playing on the client, PMPD displays the 1080p icon.

Ah. After adjusting the css you may need to do a force refresh of the browser for it to update.

As for the "now playing". Yes, I know there is a bug there. I would like to fix it in the next few days if possible. It's just trying to get the right data from the API.

How do you have separate audio files from your video files?

@titelies
Copy link
Author

titelies commented Apr 1, 2021

As usual @ZeroCoolGOS ... you are correct the Force Refresh worked, I was able to set Landscape to 12% and Vertical to 30% which looks better for my TV setup. Thank you.

I process my Blu-Ray discs with MakeMKV and then HandBrake the file to have a Stereo, 5.1, and 7.1 audio file for most of my collection. Stereo files work great for most of my clients, and then I use the 5.1 file in my living room setup and the 7.1 file for my home theater that has 9.1 surround sound.

@ZeroCoolGOS
Copy link

@titelies

That is pretty cool. This year I will need to up my Plex server game and be able to hold that amount of data. 😄

Would you be able to send me a copy of the XML for one of those media titles so I can review the information and see what changes I would need to make?

@titelies
Copy link
Author

titelies commented Apr 1, 2021

Just a thought @ZeroCoolGOS ... spacing can be forced by editing the current icons to be layered over a larger black rectangle that is a few pixels larger on all 4 sides. I will get you an XML for a media file.

ZeroCoolGOS added a commit to ZeroCoolGOS/Plex-Movie-Poster-Display that referenced this issue Apr 3, 2021
Enhancement: Images to the bottom of Now Showing for resolution, sound format, and aspect ratio (Issue MattsShack#74)
- Add padding to information icons so they don't sit up against each other.
- Adjust sizing of info icons to be a little smaller
- Update 'TV-' icons to more match film colors and make a bit easier to read.
- Add TV-G icon
- Update icon logic to eliminate empty icon if not available.

Updates and Bug Fixes:
- Update missed information in ChangeLog for 2.11.5
ZeroCoolGOS added a commit to ZeroCoolGOS/Plex-Movie-Poster-Display that referenced this issue Apr 3, 2021
Enhancement: Images to the bottom of Now Showing for resolution, sound format, and aspect ratio (Issue MattsShack#74)
- Add padding to information icons so they don't sit up against each other.
- Adjust sizing of info icons to be a little smaller
- Update 'TV-' icons to more match film colors and make a bit easier to read.
- Add TV-G icon
- Update icon logic to eliminate empty icon if not available.

Updates and Bug Fixes:
- Update missed information in ChangeLog for 2.11.5
- Update tokenCheck.php to point to settings/general.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants