Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle @NotNull #30

Open
3 tasks
MaulingMonkey opened this issue Aug 9, 2019 · 0 comments
Open
3 tasks

Handle @NotNull #30

MaulingMonkey opened this issue Aug 9, 2019 · 0 comments
Labels
api-change Breaking API change enhancement New feature or request java bindgen How Java types are automatically exposed to Rust
Milestone

Comments

@MaulingMonkey
Copy link
Owner

MaulingMonkey commented Aug 9, 2019

  • Bound JNI functions should not accept Option s for parameters that are marked @NotNull
  • Bound JNI functions should perhaps faux-throw on null instead of returning Option s for return values that are marked @NotNull
  • Invoke Objects.requireNonNull on violation?

@Nullable also exists, but is kinda the default assumption I'm making...

Note there's a whole slew of competing annotation implementations:

@MaulingMonkey MaulingMonkey added enhancement New feature or request api-change Breaking API change labels Aug 9, 2019
@MaulingMonkey MaulingMonkey added this to the 1.0.0 milestone Aug 9, 2019
@MaulingMonkey MaulingMonkey modified the milestones: 1.0.0, 2.0.0 Aug 23, 2019
@MaulingMonkey MaulingMonkey added the java bindgen How Java types are automatically exposed to Rust label Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Breaking API change enhancement New feature or request java bindgen How Java types are automatically exposed to Rust
Projects
None yet
Development

No branches or pull requests

1 participant