Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing default shorcut #13

Open
pasau opened this issue Oct 18, 2017 · 5 comments
Open

changing default shorcut #13

pasau opened this issue Oct 18, 2017 · 5 comments

Comments

@pasau
Copy link

pasau commented Oct 18, 2017

How can i change the shortcut Alt+Shift+R to something else? i tried editing manifest.json, but firefox sees the extension as unsecure then.

@Max-Github
Copy link
Owner

In chrome this can be done here:
chrome://extensions/configureCommands

I am not sure of the Firefox equivalent

You can try to use the following addon:
https://addons.mozilla.org/en-US/firefox/addon/keybinder/

@Max-Github
Copy link
Owner

If you want to add an option for setting the shortcut on the preferences page, you are welcome to submit a pull request.

@iam-TJ
Copy link

iam-TJ commented Feb 14, 2018

I've added functionality for this. It will require merging my pull-request #15 first.

My branch is at:

https://github.com/iam-TJ/FireFoxInvertColors/tree/set_shortcut_key

But due to a lack of support in the Firefox web extensions API we cannot as-yet change the shortcut key assigned by the manifest.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1325692

@Max-Github
Copy link
Owner

This is something that should be centrally controlled by the browser itself. As it is a given that there are/will be situations where keyboard bindings are going to clash.

So set_shortcut_key would allow users to have the default key binding, and what ever else they select. Am I understanding this correctly?

@iam-TJ
Copy link

iam-TJ commented Feb 17, 2018

The code - as I've written it - replaces the extension-set shortcut (since the default may conflict with other user shortcuts).

The upstream bug reports suggest the Moz devs are planning on a user interface for reviewing/controlling shortcuts, but also an extension API for changing the shortcut in a conflict-free manner.

I'll watch what happens and modify the changeset if necessary once the functionality lands in FF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants