Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitle support plans? #44

Open
akvadrako opened this issue Jun 20, 2021 · 3 comments
Open

Subtitle support plans? #44

akvadrako opened this issue Jun 20, 2021 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@akvadrako
Copy link

Hello. I am looking for an alternative to Chromecast because the support on all Linux video players is not very good; my biggest issue is subtitle handling. NymphCast seems very promising as a early project.

I gather so far it doesn't support subtitles at all. Is this something that's planned? Or, do those familiar with the design know if this would be something easy to add?

@MayaPosch
Copy link
Owner

Thank you for your interest in NymphCast.

Subtitles are supported in NymphCast's core, but aren't shown by default yet, and no controls are exposed within the NymphCast client or library so far.

Adding the ability to toggle different subtitle streams on would be mostly a matter of determining the most effective UI for this. Since video containers can contain multiple subtitle streams, I'd imagine that having the ability to choose a subtitle stream directly (from a list) would be convenient.

I will take a look at implementing this feature. If you or anyone else has some specific ideas or thoughts on preferred UX patterns here, I'd appreciate adding them to this ticket :)

@MayaPosch MayaPosch added the enhancement New feature or request label Jun 22, 2021
@MayaPosch MayaPosch added this to the v0.1 milestone Jun 22, 2021
@akvadrako
Copy link
Author

Sounds good and thanks for the quick feedback. Choosing from a list would be fine, as would keyboard shortcuts to cycle through them and turn them on/off. A nice to have is the ability to add external subtitles while a movie is playing.

@MayaPosch
Copy link
Owner

The current version of the player now features buttons to switch between subtitles as well as video & audio streams.

At some future point this will be changed to open a list to choose from rather than merely switch between streams. This, along with providing custom subtitles, will require a bit more work on the side of the server.

NymphCast is currently in feature freeze for v0.1. These new features will be added to the development for v0.2, which should start later this year.

@MayaPosch MayaPosch modified the milestones: v0.1, v0.2 Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants