Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for p256m driver #77

Open
8 tasks
ronald-cron-arm opened this issue Oct 3, 2023 · 0 comments
Open
8 tasks

Add support for p256m driver #77

ronald-cron-arm opened this issue Oct 3, 2023 · 0 comments
Labels
enhancement New feature or request size-m Estimated task size: medium (~1w)

Comments

@ronald-cron-arm
Copy link
Contributor

The goal of this issue is to add the p256m driver in psa-crypto.

List of tasks to be done (may not be comprehensive):

  • Add copy of directory p256m into drivers/p256m
  • Add a drivers/CMakeLists.txt similar to the 3rdparty/CMakeLists.txt one (only p256m, not everest)
  • Add a drivers/p256m/CMakeLists.txt (do we need to install the p256m includes as in mbedtls?)
  • In core/CMakeLists.txt add two target_link_libraries( ... PRIVATE p256m) like in library/CMakeLists.txt (not PUBLIC p256m but PRIVATE p256m though I'd say).
  • Add PSA_CRYPTO_P256M_DRIVER_ENABLED config option and its documentation in the section "PSA driver interface implementation configuration options" of crypto_config.h. Similar to MBEDTLS_PSA_P256M_DRIVER_ENABLED in mbedtls. Disabled by default.
  • Add its translation to MBEDTLS_PSA_P256M_DRIVER_ENABLED in config_adjust_mbedtls_from_psa_crypto.h.
  • Add a test_ccm_aes_sha256_secp256r1_p256m test component based on the configs/ccm-aes-sha256-secp256r1.h reference configuration with PSA_CRYPTO_P256M_DRIVER_ENABLED enabled similar to the test_tfm_config_p256m_driver_accel_ec test component in mbedtls.
  • Check that the test component do what it intends to do and give evidence of this in this issue or the associated PR for the benefit of reviewers.
@ronald-cron-arm ronald-cron-arm added the enhancement New feature or request label Oct 3, 2023
@ronald-cron-arm ronald-cron-arm added the size-m Estimated task size: medium (~1w) label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size-m Estimated task size: medium (~1w)
Projects
Status: PSA repo Q4 - all.sh components
Development

No branches or pull requests

1 participant