Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on what to do on individual submission page refresh #140

Open
michael-small opened this issue Aug 6, 2019 · 0 comments
Open

Decide on what to do on individual submission page refresh #140

michael-small opened this issue Aug 6, 2019 · 0 comments
Labels
bug Something isn't working question Further information is requested

Comments

@michael-small
Copy link
Collaborator

michael-small commented Aug 6, 2019

As of writing this issue, refreshing a submission card's page makes the page lose the data of the abstract, as that data is only grabbed and displayed once via submissionView.component.ts' getSubmission() when clicking an abstract from the list and navigating to that page http://URL:9000/abstract/{{abstract_id}}.

On URSA, the URL of particular submissions is the same as the submissionList, and refreshing the page on a particular submission dumps the user back on the home page. Not sure if this is intentional or a bug on their end, and especially not sure if it is worth emulating in the new design. If anything, if intentional but somewhat buggy, it should dump the user back on the submissionList.

My leaning is retain a dedicated abstract URL like the current implementation AND allow the data to be retained permanently on the page, no matter where the user comes from or if they refresh. This would require some refactoring in how a single abstract is displayed. Benefits would include being able to link to an abstract directly and the user losing their place, though perhaps that may introduce bugs (ask me for the backstory behind particular bugs that may be expected, long story).

@michael-small michael-small added bug Something isn't working question Further information is requested labels Aug 6, 2019
michael-small added a commit that referenced this issue Aug 6, 2019
Minimal styling and almost no logic. Follow conventions from URSA for
now. "More Details" dropdown with more abstract info still needed, as
well as comment sidebar. Once those are all in, the page can be fully
styled with additional logic. Many issues arose in consideration of
this commit, so see the detailed issues linked below.

Issue #132 (Navigate to individual submission from submission list)
Epic #131 (Submission Card View)

Misc issues spawned in the creation of these commits:
Issue #137 (Generate IDs for new abstracts)
Issue #139 (Require both first & last names if optional advisers are
added)
Epic #140 (Submission Form)
Issue #140 (Decide on what to do on individual submission page refresh)
Issue #141 (Use material colors from theme on submission page)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant