Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit abstracts as student user #262

Open
michael-small opened this issue Feb 20, 2020 · 0 comments
Open

Edit abstracts as student user #262

michael-small opened this issue Feb 20, 2020 · 0 comments

Comments

@michael-small
Copy link
Collaborator

What should be editable is pending approval by my bosses. Starting anyways.
michael-small added a commit that referenced this issue Feb 20, 2020
@michael-small
Create edit abstract page
e643fa6 
Route set up. Submission loaded in. This will be where abstract
editing will happen. For the moment I am only considering this page
from the view of a student user.

Issue #262 (Edit abstracts as student user)
Epic #131 (Submission Card View)
michael-small added a commit that referenced this issue Feb 20, 2020
@michael-small
Add basic, likely editable fields to abstract editor
0a915ca 
Issue #262 (Edit abstracts as student user)
Epic #131 (Submission Card View)
michael-small added a commit that referenced this issue Feb 20, 2020
@michael-small
Add all fields to student abstract editor
f67e329 
All the fields on the editing page are now filled in. There is no
save function yet and the CSS is ugly, but here is the barebones.

Issue #262 (Edit abstracts as student user)
Epic #131 (Submission Card View)
michael-small added a commit that referenced this issue Feb 20, 2020
@michael-small
Reorder abstract editor fields on the page
f5cc35f 
Issue #262 (Edit abstracts as student user)
Epic #131 (Submission Card View)
michael-small added a commit that referenced this issue Feb 22, 2020
@michael-small
Save entered text in abstract editor
4cdb3e7 
Text fields were not updating the content as `$event.target.value`
was missing.

This also fixed some bugs about how I lazily copied and pasted some
of the inputs around, so some fields were altering other ones.

Issue #262 (Edit abstracts as student user)
Epic #131 (Submission Card View)
michael-small added a commit that referenced this issue Feb 22, 2020
@michael-small
Fix editAbstract checkboxes bug
31cba56 
The checkboxes would initialize with their given value, but would
not update the visual state (checked or not) until a second click.
However, the state actually changed with each click. Therefore, the
visual checkbox and actual state were the exact opposite of what the
user intended to check.

A fix to this is provided by the below link... down to changing
`(click)` to `(change)` and explicitly checking `[checked]` values
to be `true`.

Fix courtesy of Hrishikesh Kale,
April 10 '18 @https://stackoverflow.com/a/49749782

Issue #262 (Edit abstracts as student user)
Epic #131 (Submission Card View)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michael-small