Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞]: Wilder Wild Hollowed Logs Have odd Textures and BOP Palm Variant Missing #734

Closed
4 tasks done
PoseironDire opened this issue Dec 23, 2024 · 18 comments
Closed
4 tasks done
Labels
1.21.1-FABRIC Minecraft Version bug Something isn't working
Milestone

Comments

@PoseironDire
Copy link

Code of Conduct

  • Always check you are using the latest version of the mods and its dependencies
  • Remove mod that enhances Minecraft: Optifine, Sodium, others. The issue still persists.
  • If you are unsure which mod is the culprit.
    Disable all of your mods and enable them 1-2 mods each time to isolate the culprit
  • Confirm that there is no existing issue with a similar description submitted in the list of issues.

Version - Loader (DO NOT FORGET TO SELECT THE CORRECT VERSION)

1.21.1 - FABRIC

EveryCompat Version

everycomp-1.21-2.7.6-fabric

Moonlight Lib Version

moonlight-1.21-2.17.12-fabric

Issue with mods

BiomesOPlenty-fabric-1.21.1-21.1.0.7 and deeperdarker-fabric-1.21-1.3.2.1.

Issue Detail

Hollowed Logs from WilderWild-3.0.11-mc1.21.1 have broken(ish) textures for the mods i listed above (perhaps for other mods too) and the Biomes O' Plenty Palm Hollowed log is missing. Also Every Compat 2.8+ does not have the hollowed logs at all
2024-12-23_14 49 40
2024-12-23_14 51 03

OPTIONAL: Latest.log | Crash-report Attachment

No crashed, just unintentional game design.

OPTIONAL: To Produce

Download fabric-api-0.110.0+1.21.1, BiomesOPlenty-fabric-1.21.1-21.1.0.7, GlitchCore-fabric-1.21.1-2.1.0.0, everycomp-1.21-2.7.6-fabric (for the broken textures) || everycomp-1.21-2.8.2-fabric (to see the Hollowed Logs missing), moonlight-1.21-2.17.12-fabric, TerraBlender-fabric-1.21.1-4.1.0.5, WilderWild-3.0.11-mc1.21.1 (All latest version as of posting this). Load into a creative world. Observe the Every Compat Tab...

@PoseironDire PoseironDire added the bug Something isn't working label Dec 23, 2024
@github-actions github-actions bot added the 1.21.1-FABRIC Minecraft Version label Dec 23, 2024
@PoseironDire
Copy link
Author

The Images were taken in my modpack, but i tried a modpack with only the mods i mentioned in the "To Produce" section and had the same effect.

@Xelbayria
Copy link
Collaborator

Alright, I need the ID of these hollow_log so i can take a close look

@PoseironDire
Copy link
Author

Should I send those IDs? And if so, all of them? I'm pretty sure most logs are affected, even beyond the mods i used, since as i mentioned; 2.8.0+ versions of Every Compat doesn't even have those hollowed logs at all, and the palm log for BOP is completely missing. But if it helps i'll do what i can, just tell me more specifically what you need.

@Xelbayria
Copy link
Collaborator

you can provide the IDs of these affected logs. so i can take a look at what's the problem.

Every Compat doesn't even have those hollowed logs at all

U meant they aren't generated at all?

the palm log for BOP is completely missing

sounds like it's not included to generate the hollow_log.

@PoseironDire
Copy link
Author

PoseironDire commented Dec 23, 2024

Do you want the log IDs from Every Compat or the other mods affected? Not sure if this is what you were asking for: deeperdarker:echo_log biomesoplenty:jacaranda_log biomesoplenty:fir_log biomesoplenty:redwood_log biomesoplenty:maple_log biomesoplenty:pine_log biomesoplenty:hellbark_log biomesoplenty:empyreal_log biomesoplenty:dead_log biomesoplenty:mahogany_log biomesoplenty:willow_log biomesoplenty:umbran_log biomesoplenty:magic_log and lastly biomesoplenty:palm_log (their stripped variants too)

@Xelbayria
Copy link
Collaborator

I should be more clear. What i am looking is the ID of generated Blocks from EC.

like this: everycomp:q/biomesoplenty/hollowed_fir_log

you can see the id from ☝🏻 will tell me which wood mods and furniture mod is Quark

with that, i can look at the texture of the generated block to see what's wrong.

@FreyrDev
Copy link

Yeah I just discovered the missing hollow logs issue with everycomp 2.8.0+ which I think is the more serious problem here, the relevant lines in everycomp-entries.json ("wilderwild.hollowed_log" and wilderwild.stripped_hollowed_log) get removed completely when loading with 2.8.0+.

For reference when checking in everycomp 2.7.6, the only log I have loaded that has that texture problem is everycomp:ww/blockus/hollowed_white_oak_log.

@Xelbayria
Copy link
Collaborator

Let's not focus on the 2.7.6. it's an older version. what I want to focus is the v2.8.0+

because 2.8.0 has major changes in the code to support an addon which will be coming in the future.

@Xelbayria
Copy link
Collaborator

Xelbayria commented Dec 29, 2024

ok back to work on this. and discovered that it wasn't EveryComp's issue.

WilderWild has supports for other wood mods. You need to report that to them. EDIT: ignore the strike-through. I checked and I think it only support the recipe stuff

One more thing, WildWilder support on EveryCompat were disabled. Will enable it in the next version.


EDIT:

Hang on.

🤔 The only mod I know has Hollowed_log are Twilight Forest, you don't happened to have it installed?

If so, then that's normal.

@Xelbayria Xelbayria added the invalid This doesn't seem right label Dec 29, 2024
@Xelbayria
Copy link
Collaborator

FYI, I moved the WilderWild Module to "COMMON" because it can be supported on FORGE with Sinytra Connector. I forgot to "enable" it via COMMON. the FABRIC was disabled and removed.

@Xelbayria Xelbayria added this to the 1.21-2.8.3 milestone Dec 29, 2024
@Xelbayria
Copy link
Collaborator

Xelbayria commented Dec 29, 2024

RE-ENABLED WilderWild Module in v2.8.3


Forgot to enable WilderWild Module after being moved to COMMON

@Xelbayria
Copy link
Collaborator

Closing this now. This is no longer relevant.

@FreyrDev
Copy link

This should probably be reopened. Now that the disappearing logs have been fixed, the texture issue that was originally reported is back in the latest version.

@Xelbayria
Copy link
Collaborator

This should probably be reopened. Now that the disappearing logs have been fixed, the texture issue that was originally reported is back in the latest version.

If you are talking about the weird texture. that's because EveryCompat supported three mods: Wilder Wild, Quark & The Twilight Forest

they all have hollow_log

if that's not the same issue. you need to be more specific. with your message, i only can guess what was the problem.

@FreyrDev
Copy link

Ah fair I guess the problem isn't that obvious in the OP's screenshots. This is what I mean with everycomp:ww/blockus/hollowed_white_oak_log:

2024-12-30_22 42 17

It's using colours from the inside wood instead of just the bark (This is the regular hollow log, not the stripped version). OP was probably also pointing out that logs with a more unusual pattern – as seen on the left side of their first screenshot – end up using a texture for hollow logs that's pretty different from the base logs, though I'm not sure how fixable that is given my (limited) understanding of how everycompat works.

(Also I'll just note that I have neither Quark nor The Twilight Forest installed)

@Xelbayria
Copy link
Collaborator

Xelbayria commented Dec 31, 2024

oh that image helped a lot. I know what's the problem. Can you create a new issue with the information above.

EDIT:

It's using colours from the inside wood instead of just the bark

That's exactly the problem. you are correct. its' an easy fix.

EDIT 2:

nvm. it's Finished.

@Xelbayria Xelbayria removed the invalid This doesn't seem right label Dec 31, 2024
@Xelbayria
Copy link
Collaborator

@FreyrDev

can you check to see if biomesplenty:palm has stripped_log`. if not, then that would explain why

the Biomes O' Plenty Palm Hollowed log is missing

@Xelbayria
Copy link
Collaborator

FIXED in v2.8.5


generating textures using the wrong side of the texture for hollow_log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1-FABRIC Minecraft Version bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants