Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

states should use either static config provider or config.FromEnv() #698

Open
adrianchiris opened this issue Dec 4, 2023 · 1 comment
Open

states should use either static config provider or config.FromEnv() #698

adrianchiris opened this issue Dec 4, 2023 · 1 comment
Labels
refactoring Code refactoring

Comments

@adrianchiris
Copy link
Collaborator

adrianchiris commented Dec 4, 2023 •
edited
Loading

Different states use different ways to get "deploy time configurations"/"static configurations"

  • via staticconfig provider
  • via config package

both eventually get info from env variables.
we should use only one way taking into account ease of testability and simplicity.
@adrianchiris adrianchiris added the refactoring Code refactoring label Dec 4, 2023
@adrianchiris adrianchiris mentioned this issue Dec 4, 2023
Merged
@adrianchiris
Copy link
Collaborator Author

adrianchiris commented Dec 4, 2023 •
edited
Loading

My inputs:
it doesnt really matter which way we go as long as we are consistent. leaving it for the implementor to decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adrianchiris