Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize to use compose for all postgres testing #317

Closed
sebastianswms opened this issue Dec 13, 2023 · 0 comments · Fixed by #320
Closed

Standardize to use compose for all postgres testing #317

sebastianswms opened this issue Dec 13, 2023 · 0 comments · Fixed by #320

Comments

@sebastianswms
Copy link
Collaborator

Currently we use a combination of a postgres service and docker compose to create postgres instances for pytesting. This should be standardized to use compose for everything.
@sebastianswms sebastianswms mentioned this issue Dec 14, 2023
Merged
visch pushed a commit that referenced this issue Dec 15, 2023
@sebastianswms
feat: Switch from postgres service to compose (#320)
2eddf32 
Remove the postgres service from `test.yml` and add an additional
postgres container to `docker-compose.yml`.

Closes #317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
MeltanoLabs Overview
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Switch from postgres service to compose sebastianswms/tap-postgres
1 participant
@sebastianswms