Log Based Replication not working with SSH Tunnel

[axel-lcdp]

When using SSH Tunnel, we cannot replicate tables using logicial LogBased Replication.

The function responsible for the replication is in tap_postgres/client.py > logical_replication_connection line 520.

The connection is using the raw config to connect to the database, however, it should be using the SQLAlchemy URL because it has been modified to handle the new host and port through the SSH tunnel (in the file tap_postgres/tap.py line 427).

[visch]

@axel-lcdp thank you for this issue!

@axel-lcdp yes you're right this function needs updating

tap-postgres/tap_postgres/client.py

Lines 520 to 534 in ab3f4dc

	def logical_replication_connection(self):
	"""A logical replication connection to the database.
	Uses a direct psycopg2 implementation rather than through sqlalchemy.
	"""
	connection_string = (
	f"dbname={self.config['database']} user={self.config['user']} password="
	f"{self.config['password']} host={self.config['host']} port="
	f"{self.config['port']}"
	)
	return psycopg2.connect(
	connection_string,
	application_name="tap_postgres",
	connection_factory=extras.LogicalReplicationConnection,
	)

We'll take PRs. I'm surprised we missed this during our testing!

[axel-lcdp]

No problem ! I will see what I can do.