Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SQLAlchemy 2 #28

Closed
edgarrmondragon opened this issue Aug 3, 2023 · 0 comments · Fixed by #44
Closed

Use SQLAlchemy 2 #28

edgarrmondragon opened this issue Aug 3, 2023 · 0 comments · Fixed by #44

Comments

@edgarrmondragon
Copy link
Member

Blocked by:
@pnadolny13 pnadolny13 mentioned this issue Aug 8, 2023
Closed
@haleemur haleemur mentioned this issue Sep 6, 2024
Merged
edgarrmondragon added a commit that referenced this issue Sep 9, 2024
@haleemur @edgarrmondragon
feat: Update dependencies (sqlalchemy, singer-sdk) (#44)
86a73b2 
# Description

- Update sqlalchemy, singer-sdk & snowflake-sqlalchemy to latest
avaiable versions
- Resolve Deprecation warning by replacing usage of
`SQLConnector.connection` with new child method
`SnowflakeConnector.execute`

closes: #28

#31 would be outdated if this gets merged, and I recommend we close
that.

---------

Co-authored-by: Edgar Ramírez-Mondragón <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
MeltanoLabs Overview
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Update dependencies (sqlalchemy, singer-sdk) haleemur/tap-snowflake
1 participant
@edgarrmondragon