-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi test into simfix
#17
Comments
I thought it is more general to provide a list of functions with standardized input and output. Use case; what if you want to perform simulation to compare WLR, RMST and milestone test. In this way, you also have a framework to allow user defined function. |
Perhaps something like this? simfix(
sampleSize = 500,
targetEvents = 350,
strata = strata_df(...),
enrollRates = enroll_rates(...),
failRates = fail_rates(...),
totalDuration = 30,
block = rep(c("Experimental", "Control"), 2),
timingType = 1:5
) |>
test_name_1() |>
test_name_2(arg1 = 0, arg2 = 0)|>
test_name_2(arg1 = 0, arg2 = 0.5) |>
run_sim(n = 3) |
Decision: let's focus on the data table first, and save this issue as low priority for now. The test list should be independent of |
Now after talking about this today I think Yilong's suggestion makes sense. For defining the tests, a function factory pattern like the ggplot2 scales or encapsulated OOP like R6 might be good solutions. We do need to change the arguments from the simple |
The text was updated successfully, but these errors were encountered: