Do not center to geometry when highlighting when geometry does not fit the screen #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11556198782Details
💛 - Coveralls |
ValentinBuira
changed the title
VitorVieiraZ
approved these changes
Oct 28, 2024
|
There is one things left that bother me, it's that in some cases you, since we don't offset the view, you can hide the highlighted feature with the pop-up, see the attached video Screencast.from.2024-10-28.15-34-54.webmI am working on a fix but I can do it in a separate PR |
PeterPetrik
approved these changes
Oct 31, 2024
| @@ -316,6 +316,25 @@ QPointF InputUtils::geometryCenterToScreenCoordinates( const QgsGeometry &geom, | |||
| return screenPoint; | |||
| } | |||
|
|
|||
| bool InputUtils::canExtentContainGeometry( const QgsGeometry &geom, InputMapSettings *mapSettings ) | |||
There was a problem hiding this comment.
I suggest to rename canExtentContainGeometry to extentContainGeometry
| * Returns the true if the geometry could fully be contained in the current screen otherwise false | ||
| * Geometry must be in canvas CRS | ||
| */ | ||
| Q_INVOKABLE bool canExtentContainGeometry( const QgsGeometry &geom, InputMapSettings *mapSettings ); |
There was a problem hiding this comment.
maybe worth to have simple unit test ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the ux-unfriendly behavior when in some scenario (concave shaped, or too big) the user would highlight a feature and the extend would either not move to the feature or move quite a lot.
The new behaviors works by not jumping to the feature if the feature can not be fully contained within the current extend size
Example both jumping and not jumping in the same video:
Screencast from 2024-10-25 11-46-47.webm
Fix #3559