-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid copying of versioned files #30
Comments
We currently trigger sqlite checkpoint manually before push. Also we download geodiff changeset files whenever possible.
|
There is SQLite API for copying sqlite databases which should be hopefully safer than verbatim copies and dealing with checkpoints/vacuum: https://sqlite.org/backup.html |
The new geodiff 1.0 will have GEODIFF_makeCopySqlite(src, dst) which will allow safe copying. And we should not even need to do checkpoint/vacuum anymore. |
In case of geodiff supported files we should completely avoid copying files since they can be open with some clients in WAL mode and thus changes would be lost.
We need either to flush changes right before copy or not to copy at all (might be impossible in some cases). Also we need to investigate how robust is geodiff sync against data loss when some file is still open by 3rd client (e.g. modified between pull and push)
The text was updated successfully, but these errors were encountered: