Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meros exits with an error message from GTK when the GUI is used despite no display server running. #301

Open
kayabaNerve opened this issue May 5, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@kayabaNerve
Copy link
Member

This is due to the recent GUI upgrade. Notably, changed functionality in Webview 0.10.0.

webview/webview#571 is the upstream issue and I have submitted a PR to re-enable 0.1.1 functionality.

@kayabaNerve
Copy link
Member Author

Since moving to Wry, we no longer segfault, yet we do error beyond our control and don't print our nice error message. Wry issue 265 being implemented into mc_wry should close this issue. That said, there is an edge case for Linux where WebView is installed yet not usable due to the tty being used/Xorg not being started I'm concerned about.

@kayabaNerve kayabaNerve changed the title Meros segfaults when the GUI is used on a platform without a GUI available. Meros exits with a debug message when the GUI is used on a platform without a GUI available. May 22, 2021
@kayabaNerve kayabaNerve changed the title Meros exits with a debug message when the GUI is used on a platform without a GUI available. Meros exits with an error message from GTK when the GUI is used despite no display server running. May 22, 2021
@kayabaNerve
Copy link
Member Author

kayabaNerve commented May 22, 2021

While 265 did decrease the chances of this happening, it solely applied to WebView being installed; not being available, as somewhat expected. tauri-apps/tao#74 is the issue with the window creation library for being able to handle this. I also did work out a Linux-only version which would manually implement the specified fix, putting the burden on us to check and maintain, which is here.

Said file does change a null pointer return to returning 1 casted to a pointer. For some reason, things didn't work without it. First it said it was valid before segfaulting because it wasn't, then it returned SIGILL when I added a print statement... really weird behavior. Returning a pointer of 1 just works though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant