Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSET_*_CYCLE_POINT variables clash with general definition of cycle point #674

Closed
jfrost-mo opened this issue May 31, 2024 · 1 comment
Closed
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@jfrost-mo
Copy link
Member

Describe the bug

By convention a forecast cycle refers to its initiation time (as has always been the way in the RES) thus this is what many will instinctively think of when setting any of the data with CYCLE in the name.

Currently in CSET the CYCLE variables refer to the variable being CYCLED over in Cylc. This is not clear, either the naming convention in CSET needs to change or the documentation should be improved to provide this clarity. I would suggest the former.

Note

This may become more obvious when multiple forecast cycles can be added into CSET, but will be important for when running RAL trials, and is vital for me [@daflack] switching between Services and RMED to aid the transitions each month.

FURTHER COMMENT: cycling via datatime could fix this and reduce this confusion.

@jfrost-mo jfrost-mo added bug Something isn't working documentation Improvements or additions to documentation labels May 31, 2024
@jfrost-mo jfrost-mo added this to the 2024-05 Usability Review milestone May 31, 2024
@jfrost-mo
Copy link
Member Author

Fixed in #765.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant