Remove KeyringController
methods that are not keyring-agnostic
#5153
Labels
KeyringController
methods that are not keyring-agnostic
#5153
KeyringController
currently provides some methods specific to certain types of keyrings (that is, certain Keyring classes). Though, KeyringController should be managing all keyrings in the same way, and its API should provide access to keyrings in a generic manner, agnostic to the specific keyring type the consumer wants to interact with.This should include removing all methods related to the QR keyring, as well as all other methods which are not applicable to the generic Keyring type, like:
addNewAccount
as it is a specific method for the mainHDKeyring
addNewAccountForKeyring
as it is not compatible with all keyrings, and does not guarantee that the keyring passed is even managed byKeyringController
importAccountWithStrategy
as it is only applicable toSimpleKeyring
SimpleKeyring
builder options, with some adjustments to how theSimpleKeyring
class handles initialization paramsexportSeedPhrase
as it is only applicable toHDKeyring
exportAccount
as it is only compatible withHDKeyring
andSimpleKeyring
getQRKeyring
as it is a QR-specific methodgetOrAddQRKeyring
restoreQRKeyring
resetQRKeyringState
getQRKeyringState
submitQR*
cancelQR*
connectQRHardware
unlockQRHardwareWalletAccount
forgetQRDevice
The text was updated successfully, but these errors were encountered: