Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On a fresh install stylelint dispalys warnings #118

Open
rsanzante opened this issue May 14, 2023 · 1 comment
Open

On a fresh install stylelint dispalys warnings #118

rsanzante opened this issue May 14, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@rsanzante
Copy link
Member

rsanzante commented May 14, 2023 •
edited
Loading

When composer create-project metadrop/drupal-boilerplate projectname is run and the create Radix subtheme is selected, the stylelint is run during the frontend assets build. Stylelint detects more than 100 warnings.

All warnings can be classified in the following types:

  • Using single quotes instead of double quotes
  • Wrong indentation (number of spaces)

Example of the stylelint output for the 3.x brahch (drupal 10):

WARNING in [stylelint] 
src/scss/_init.scss
  1:9  ✖  Expected double quotes              string-quotes
  2:1  ✖  Expected empty line before comment  scss/double-slash-comment-empty-line-before
  3:9  ✖  Expected double quotes              string-quotes
  6:9  ✖  Expected double quotes              string-quotes
  7:9  ✖  Expected double quotes              string-quotes
  8:9  ✖  Expected double quotes              string-quotes
  9:9  ✖  Expected double quotes              string-quotes
 10:9  ✖  Expected double quotes              string-quotes
 11:9  ✖  Expected double quotes              string-quotes
 14:9  ✖  Expected double quotes              string-quotes

src/scss/main.style.scss
 3:9  ✖  Expected double quotes  string-quotes
 7:9  ✖  Expected double quotes  string-quotes

src/components/offcanvas/_offcanvas.scss
   4:2   ✖  Expected indentation of 2 spaces  indentation
   6:2   ✖  Expected indentation of 2 spaces  indentation
   7:2   ✖  Expected indentation of 2 spaces  indentation
   8:2   ✖  Expected indentation of 2 spaces  indentation
   9:2   ✖  Expected indentation of 2 spaces  indentation
  10:2   ✖  Expected indentation of 2 spaces  indentation
  11:2   ✖  Expected indentation of 2 spaces  indentation
  12:2   ✖  Expected indentation of 2 spaces  indentation
  13:2   ✖  Expected indentation of 2 spaces  indentation
  14:2   ✖  Expected indentation of 2 spaces  indentation
  15:2   ✖  Expected indentation of 2 spaces  indentation
  16:2   ✖  Expected indentation of 2 spaces  indentation
  17:3   ✖  Expected indentation of 4 spaces  indentation
  18:2   ✖  Expected indentation of 2 spaces  indentation
  20:2   ✖  Expected indentation of 2 spaces  indentation
  21:2   ✖  Expected indentation of 2 spaces  indentation
  22:2   ✖  Expected indentation of 2 spaces  indentation
  22:13  ✖  Expected double quotes            string-quotes
  23:2   ✖  Expected indentation of 2 spaces  indentation
  23:13  ✖  Expected double quotes            string-quotes
  24:2   ✖  Expected indentation of 2 spaces  indentation
  24:13  ✖  Expected double quotes            string-quotes
  25:2   ✖  Expected indentation of 2 spaces  indentation
  25:13  ✖  Expected double quotes            string-quotes
  26:2   ✖  Expected indentation of 2 spaces  indentation
  26:13  ✖  Expected double quotes            string-quotes
  27:2   ✖  Expected indentation of 2 spaces  indentation
  27:13  ✖  Expected double quotes            string-quotes
  28:2   ✖  Expected indentation of 2 spaces  indentation
  28:13  ✖  Expected double quotes            string-quotes
  29:2   ✖  Expected indentation of 2 spaces  indentation
  29:13  ✖  Expected double quotes            string-quotes
  30:2   ✖  Expected indentation of 2 spaces  indentation
  30:13  ✖  Expected double quotes            string-quotes
  31:2   ✖  Expected indentation of 2 spaces  indentation
  31:13  ✖  Expected double quotes            string-quotes
  32:2   ✖  Expected indentation of 2 spaces  indentation
  32:13  ✖  Expected double quotes            string-quotes
  33:2   ✖  Expected indentation of 2 spaces  indentation
  33:13  ✖  Expected double quotes            string-quotes
  34:2   ✖  Expected indentation of 2 spaces  indentation
  34:13  ✖  Expected double quotes            string-quotes
  35:3   ✖  Expected indentation of 4 spaces  indentation
  36:2   ✖  Expected indentation of 2 spaces  indentation
  38:2   ✖  Expected indentation of 2 spaces  indentation
  38:13  ✖  Expected double quotes            string-quotes
  39:3   ✖  Expected indentation of 4 spaces  indentation
  40:3   ✖  Expected indentation of 4 spaces  indentation
  41:3   ✖  Expected indentation of 4 spaces  indentation
  42:2   ✖  Expected indentation of 2 spaces  indentation
  44:2   ✖  Expected indentation of 2 spaces  indentation
  45:3   ✖  Expected indentation of 4 spaces  indentation
  46:3   ✖  Expected indentation of 4 spaces  indentation
  47:3   ✖  Expected indentation of 4 spaces  indentation
  48:3   ✖  Expected indentation of 4 spaces  indentation
  49:3   ✖  Expected indentation of 4 spaces  indentation
  50:3   ✖  Expected indentation of 4 spaces  indentation
  52:3   ✖  Expected indentation of 4 spaces  indentation
  53:4   ✖  Expected indentation of 6 spaces  indentation
  54:4   ✖  Expected indentation of 6 spaces  indentation
  55:3   ✖  Expected indentation of 4 spaces  indentation
  56:2   ✖  Expected indentation of 2 spaces  indentation
  58:2   ✖  Expected indentation of 2 spaces  indentation
  59:3   ✖  Expected indentation of 4 spaces  indentation
  60:3   ✖  Expected indentation of 4 spaces  indentation
  61:4   ✖  Expected indentation of 6 spaces  indentation
  63:4   ✖  Expected indentation of 6 spaces  indentation
  64:5   ✖  Expected indentation of 8 spaces  indentation
  65:5   ✖  Expected indentation of 8 spaces  indentation
  66:4   ✖  Expected indentation of 6 spaces  indentation
  67:3   ✖  Expected indentation of 4 spaces  indentation
  68:2   ✖  Expected indentation of 2 spaces  indentation
  70:2   ✖  Expected indentation of 2 spaces  indentation
  71:3   ✖  Expected indentation of 4 spaces  indentation
  72:3   ✖  Expected indentation of 4 spaces  indentation
  74:3   ✖  Expected indentation of 4 spaces  indentation
  75:4   ✖  Expected indentation of 6 spaces  indentation
  76:4   ✖  Expected indentation of 6 spaces  indentation
  77:4   ✖  Expected indentation of 6 spaces  indentation
  78:4   ✖  Expected indentation of 6 spaces  indentation
  79:3   ✖  Expected indentation of 4 spaces  indentation
  80:2   ✖  Expected indentation of 2 spaces  indentation
  82:2   ✖  Expected indentation of 2 spaces  indentation
  83:3   ✖  Expected indentation of 4 spaces  indentation
  84:3   ✖  Expected indentation of 4 spaces  indentation
  85:3   ✖  Expected indentation of 4 spaces  indentation
  86:3   ✖  Expected indentation of 4 spaces  indentation
  87:3   ✖  Expected indentation of 4 spaces  indentation
  88:3   ✖  Expected indentation of 4 spaces  indentation
  89:3   ✖  Expected indentation of 4 spaces  indentation
  90:3   ✖  Expected indentation of 4 spaces  indentation
  91:3   ✖  Expected indentation of 4 spaces  indentation
  92:3   ✖  Expected indentation of 4 spaces  indentation
  93:3   ✖  Expected indentation of 4 spaces  indentation
  94:3   ✖  Expected indentation of 4 spaces  indentation
  95:3   ✖  Expected indentation of 4 spaces  indentation
  96:2   ✖  Expected indentation of 2 spaces  indentation
  98:2   ✖  Expected indentation of 2 spaces  indentation
  99:3   ✖  Expected indentation of 4 spaces  indentation
 100:4   ✖  Expected indentation of 6 spaces  indentation
 101:3   ✖  Expected indentation of 4 spaces  indentation
 102:2   ✖  Expected indentation of 2 spaces  indentation

src/scss/base/_utilities.scss
  3:6  ✖  Expected double quotes            string-quotes
  6:2  ✖  Expected indentation of 2 spaces  indentation
  7:3  ✖  Expected double quotes            string-quotes
  7:3  ✖  Expected indentation of 4 spaces  indentation
  8:4  ✖  Expected indentation of 6 spaces  indentation
  9:4  ✖  Expected indentation of 6 spaces  indentation
 10:4  ✖  Expected indentation of 6 spaces  indentation
 11:5  ✖  Expected double quotes            string-quotes
 11:5  ✖  Expected indentation of 8 spaces  indentation
 12:4  ✖  Expected indentation of 6 spaces  indentation
 13:4  ✖  Expected indentation of 6 spaces  indentation
 14:4  ✖  Expected indentation of 6 spaces  indentation
 15:3  ✖  Expected indentation of 4 spaces  indentation
 16:3  ✖  Expected double quotes            string-quotes
 16:3  ✖  Expected indentation of 4 spaces  indentation
 17:4  ✖  Expected indentation of 6 spaces  indentation
 18:4  ✖  Expected indentation of 6 spaces  indentation
 19:4  ✖  Expected indentation of 6 spaces  indentation
 20:4  ✖  Expected indentation of 6 spaces  indentation
 21:3  ✖  Expected indentation of 4 spaces  indentation
 22:2  ✖  Expected indentation of 2 spaces  indentation
 23:2  ✖  Expected indentation of 2 spaces  indentation

136 problems (136 errors, 0 warnings)

However, using branch 2.x (Drupal 9), only 4 warnings are displayed:

src/scss/main.style.scss
 3:9  ✖  Expected double quotes  string-quotes
 7:9  ✖  Expected double quotes  string-quotes
 8:9  ✖  Expected double quotes  string-quotes
 9:9  ✖  Expected double quotes  string-quotes
@rsanzante rsanzante added the bug Something isn't working label May 14, 2023
@rsanzante rsanzante changed the title On a fresh install stylelint detects more than 100 warnings On a fresh install stylelint dispalys warnings May 14, 2023
@alzz
Copy link
Contributor

alzz commented Jul 31, 2023

This error comes from the autogenerated theme from radix 5.
We should patch the contrib theme to solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rsanzante @alzz