Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github releases may not be the latest #272

Closed
yellowhat opened this issue Aug 21, 2024 · 6 comments · Fixed by #274
Closed

Github releases may not be the latest #272

yellowhat opened this issue Aug 21, 2024 · 6 comments · Fixed by #274

Comments

@yellowhat
Copy link

Hi,

some projects may release new minor/patch releases after a new major/minor.

For example, at the time of writing https://github.com/kubernetes/kubernetes/tags:

  • v1.30.4
  • v1.29.8
  • v1.28.13
  • v1.31.0

therefore:

$ nix --extra-experimental-features "flakes nix-command" run github:Mic92/nix-update -- --flake kubernetes
...
trying to fetch https://api.github.com/repos/kubernetes/kubernetes/releases
Not updating version, already 1.30.4

nix-update assumes that 1.30.4 is the latest but it is not.

Any suggestions?

Thanks

@adamcstephens
Copy link

Is this a duplicate of #271 ?

@jian-lin
Copy link

jian-lin commented Sep 6, 2024

In 1.5.0, nix-update checks releases instead of tags. v1.31.0 is one of the tags but not one of the releases.

related: #246

@yellowhat
Copy link
Author

In 1.5.0, nix-update checks releases instead of tags. v1.31.0 is one of the tags but not one of the releases.

related: #246

1.31.0 is a release and marked as latest

image

@jian-lin
Copy link

jian-lin commented Sep 6, 2024

Ah, I missed that. I guess the causes is different from lspce then.

@lilyinstarlight
Copy link
Contributor

#246 and #269 should be reverted as mentioned in #246 (comment). That change did not actually fix any package updates (since version-regex was already the tool to help the listed motivation), but it did break many packages like this one

I've just forked and reverted myself at https://github.com/lilyinstarlight/nix-update for now so I can have an actually working nix-update in the mean time

@lilyinstarlight
Copy link
Contributor

Fixed in #274

@Mic92 Mic92 closed this as completed in #274 Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants