Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop probably unneeded metadata #313

Open
hadley opened this issue Apr 18, 2024 · 3 comments
Open

Drop probably unneeded metadata #313

hadley opened this issue Apr 18, 2024 · 3 comments

Comments

@hadley
Copy link
Collaborator

hadley commented Apr 18, 2024

It'd be nice to drop these:

"Project-Id-Version: pkgdown 2.0.9.9000\n"
"POT-Creation-Date: 2024-04-18 17:22-0500\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <[email protected]>\n"

The version and dates cause spurious git diffs and the translator info is duplicative with what you'll get from git anyway.

@MichaelChirico
Copy link
Owner

We do need those for consistency with base:

https://github.com/search?q=repo%3Ar-devel%2Fr-svn+path%3Apo+%2FProject-Id-Version%2F&type=code

I'm also not sure if these are required by gettext. But certainly we could expose an option to supply those manually --> allow idempotency.

@hadley
Copy link
Collaborator Author

hadley commented Apr 19, 2024

Maybe there could be an argument to suppress them, and it would default to true if the current project root contained a .git directory?

@MichaelChirico
Copy link
Owner

MichaelChirico commented May 2, 2024

I'm still loath to suppress them by default. Project-Id-Version is pretty ubiquitous -- 4.9 million hits on GitHub:

https://github.com/search?q=path%3A.po%20%2FProject-Id-Version%3A%2F&type=code

Similar for POT-Creation-Date and PO-Revision-Date.

So I understand why we can suppress them and back up on git to track this info, but would do so only optionally.

These are populated by msginit by default:

https://www.gnu.org/software/gettext/manual/gettext.html#msginit-Invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants