Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requiered "typ" header of token was missed #201

Open
sultansoy opened this issue Jun 2, 2020 · 2 comments
Open

Requiered "typ" header of token was missed #201

sultansoy opened this issue Jun 2, 2020 · 2 comments
Labels
is:bug Something isn't working

Comments

@sultansoy
Copy link

Describe the bug
There is no "typ": "JWT" in header

To Reproduce
Try to use RESTClient with @JwtConfig for application secured by "MP-JWT"

Expected behavior
JwtBuilder should add typ header in buildJwt method
builder.jws.setHeader("typ", "JWT");
@sultansoy sultansoy added the is:bug Something isn't working label Jun 2, 2020
@aguibert
Copy link
Member

aguibert commented Jun 5, 2020

hi @sultansoy, thanks for raising this issue. According to RFC 7519 the typ attribute is optional:
https://tools.ietf.org/html/rfc7519#section-5.1

It's easy enough to add though. Is this causing an issue with an application / runtime that is requiring it?

@appiepollo14
Copy link
Collaborator

@sultansoy is this one still relevant for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aguibert @sultansoy @appiepollo14