Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into potential cyclic objects #186

Closed
TheRealAgentK opened this issue May 3, 2024 · 0 comments · Fixed by #187
Closed

Look into potential cyclic objects #186

TheRealAgentK opened this issue May 3, 2024 · 0 comments · Fixed by #187
Assignees
@miquelbeltran

Comments

@TheRealAgentK
Copy link
Contributor

TheRealAgentK commented May 3, 2024 •
edited
Loading

This stems from a PR comment from @PanosNB:

What will happen if there a cycle in the object? Will we get a Stack Overflow if an object down the line, points back to a parent object? Can we add a test for this, if none exists?

Originally posted by @PanosNB in #182 (comment)
@github-project-automation github-project-automation bot moved this to Needs Triage in Raygun4Node board May 3, 2024
@miquelbeltran miquelbeltran self-assigned this May 3, 2024
@miquelbeltran miquelbeltran mentioned this issue May 3, 2024
Merged
11 tasks
@TheRealAgentK TheRealAgentK moved this from Needs Triage to In Review in Raygun4Node board May 6, 2024
@github-project-automation github-project-automation bot moved this from In Review to Merged in Raygun4Node board May 6, 2024
@miquelbeltran miquelbeltran moved this from Merged to Released in Raygun4Node board May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miquelbeltran miquelbeltran

Labels
None yet
Projects
Raygun4Node board
Status: Released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #186 avoid infinite recursion in filter method MindscapeHQ/raygun4node
2 participants
@TheRealAgentK @miquelbeltran