Refactor raygun.transport.ts to use Promises instead of callbaks
#197
Assignees
Labels
Comments
This was referenced May 7, 2024
miquelbeltran
added a commit
that referenced
this issue
May 9, 2024
* rename legacy send method to sendWithCallback * implemented async send wrapper * add async send test suite * update domain example to use async send * prettier run * cleanup * fix test * wip updating expressHandler to use async send * fixing tests * format * replace sendWithCallback to send * wip update docs * cleanup of sendSync * add TODOs for refactor * update README * prettier * add send bind again * cleanup test * clenaup tests * change title * Update lib/raygun.ts Co-authored-by: Sumitra Manga <[email protected]> * wrap HTTP request in Promise * fix: #198 reject promise on error * cleanup * adapt batch transport to transport with Promise * tests are passing * tests are passing * WIP * fix test * fixes and cleanup * add tags to debug loglines * improve logs in raygun.transport * fix: #140 throw error on incoming message too large * improving error logs * error cleanup * package-lock.json changes --------- Co-authored-by: Sumitra Manga <[email protected]>
github-project-automation
bot
moved this from In Progress
to Merged
in Raygun4Node board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please describe your new feature request
raygun.transport.tsuses a Callback to tell if the request completed or not.If we want to get rid of callbacks, this is the place to start!
Describe the solution you'd like
Replace the callback response with a Promise.
Describe alternatives you've considered
Additional context
Related to #196
Originally posted by @sumitramanga in #181 (comment)
The text was updated successfully, but these errors were encountered: