Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport layer: HTTP request info in batch mode #330

Closed
TheRealAgentK opened this issue Oct 15, 2024 · 1 comment
Closed

Transport layer: HTTP request info in batch mode #330

TheRealAgentK opened this issue Oct 15, 2024 · 1 comment
Assignees

Comments

@TheRealAgentK
Copy link
Contributor

Please describe your new feature request
Stemming from a discussion on #321, we want simplify the structure of the HTTP information in crash report promises when the provider runs in batch mode.

Describe the solution you'd like
When the provider is in batch mode, there's no point in building up crash report promises with HTTP request information because eventually this information is all discarded and not used. The HTTP request information for batches is used instead.

Without changing the overall flow too much, we should be able to not build up the aforementioned structure in the first place.

An alternative option might be to treat the promises in a similar way to how they are being dealt with in the case of offline status (resolving with null).

@github-project-automation github-project-automation bot moved this to Needs Triage in Raygun4Node board Oct 15, 2024
@TheRealAgentK TheRealAgentK changed the title <Area of the SDK>: <Short Description of new feature> Transport layer: HTTP request info in batch mode Oct 15, 2024
@TheRealAgentK TheRealAgentK self-assigned this Oct 15, 2024
@TheRealAgentK
Copy link
Contributor Author

Done via #332

@github-project-automation github-project-automation bot moved this from Needs Triage to Merged in Raygun4Node board Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged
Development

No branches or pull requests

1 participant