Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve Plugins.getOrNull #80

Open
0ffz opened this issue Dec 22, 2024 · 0 comments
Open

chore: Improve Plugins.getOrNull #80

0ffz opened this issue Dec 22, 2024 · 0 comments

Comments

@0ffz
Copy link
Member

0ffz commented Dec 22, 2024

Currently it cannot get plugins via a superclass, which causes issues when plugins only expose an interface but not their exact impl. This interface might also not extend Plugin, so the generic type should reflect this too.

Possible solutions:

  • Do an is check for each plugin instead of checking if classes are exactly equal, or use reflection in worst case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant