ASM 4.1 library is incompatible with Java 8

[ajfite]

Updating the library to 5.0.1 fixes compatibility issues.

[LexManos]

It can READ files compiled to TARGET Java8, It does Nothing for Compatibility with the Java8 JRE.
However, we need to setup the distribution of this file, it's ore then just editing the json files. The end users have to have some where to get these files.

[ajfite]

My only reason for the request is that MCPC+ downstream doesn't run properly with Java 8 on the 4.1 version of the library, but does with the 5.0.1 (Specifically the bukkit plugins). They wont fix it until it gets changed in Forge, so here I am!

[AbrarSyed]

Does the ASM lib API change between 4.1 and 5? if it doesnt, MCPC can easily just replace the dependency in their system.

[LexManos]

I'll eventually get some setup going, trying to convince Mojang to throw it up on there CDN. But pushing things out like that JUST editing the text file, it's the servers that host it as well.

[ajfite]

@AbrarSyed They closed my issue with them and told me that FML had to update the library before they would.

@LexManos I was under the impression that the loader downloaded its libraries from the Maven Repo servers, no idea it was the Mojang CDN doing it, good to know.

I don't really consider this an essential issue, it would just be nice to play around with the new Java 8 features in my self-developed plugins.

Edit: I'm a derp and deleted my comment, I apologize for the double emails.

[LexManos]

It uses our servers, or the Mojang servers depending on what we tell it. Not maven central.

[ajfite]

That makes sense, wouldn't want to put unnecessary load on Maven Central

On Wed, Apr 2, 2014 at 11:59 PM, LexManos [email protected] wrote:

It uses our servers, or the Mojang servers depending on what we tell it.
Not maven central.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/394#issuecomment-39418584
.

[quantumsheep]

When is the update for 1.6, I expected !

[clienthax]

just going to point out that 5.0.1 is on mojangs cdn
https://github.com/Mojang/LegacyLauncher/blob/master/build.gradle#L18

[heni123321]

to see this issue in forge
install java 8
install forge
put https://dl.dropboxusercontent.com/u/98665796/modid-1.0.jar in the mods folder. the source is in the jar
What you should see is 4 mods loaded but only 3 if you look in the console ClassReader is throwing an IllegalArgumentException

[LexManos]

Yes, you should NOT be building your mods for java8, all mods should target java6. Else you alienate ~95% of the minecraft users.
And no ASM 5 is NOT on the Mojang CDN, if you notice, I was the one that made that commit you are linking. I don't have access to upload to mojang's CDN.
On top of this, ASM 5 is NOT compatible with ASM4, which means that if we updated it'd break all coremods. We may do this, but in 1.8 as 1.7 should keep a lot of things similiar and working.

[yuuka-miya]

Should this be closed, with FML updating to ASM 5?

[LexManos]

The 5.x uptake is not complete yet I'll close it when it is done.