Skip to content
This repository has been archived by the owner on May 26, 2018. It is now read-only.

[1.8, Forge 1329] Sending packets with sendToAll kicks clients from server, error in console. #608

Open
iChun opened this issue Mar 2, 2015 · 12 comments

Comments

@iChun
Copy link
Contributor

iChun commented Mar 2, 2015

Pretty much the same issue as #588, except it was supposed to have been fixed by now. Doesn't happen all the time now though as before, more like the every second or third time the same packet is sent.

Console error:
https://gist.github.com/iChun/f13b71929ece691ddd0e

@LexManos
Copy link
Member

LexManos commented Mar 2, 2015

Compleetly different issue.
This one is caused by something malforming the packets and causing the header to look for a invalid packet by id.
What are you sending?
How much data is it?
How are you sending it?
Are you going beyond the data cap for the custom packets?
How are you registering your packet system?

Get packet logs.

@iChun
Copy link
Contributor Author

iChun commented Mar 3, 2015

I'm sending a packet of Strings and ints. At time the exception is thrown it most likely has 2 strings and an int. One of the strings are a UUID in form of string, the other is just a short one of length ~10.

Sending it by sendToAll found here: https://github.com/iChun/iChunUtil/blob/master/src/main/java/us/ichun/mods/ichunutil/common/core/network/PacketChannel.java#L41-L46

It's 2 strings and an int, no I don't think I'm going beyond the data cap.

Packet System registered in this function: https://github.com/iChun/iChunUtil/blob/master/src/main/java/us/ichun/mods/ichunutil/common/core/network/ChannelHandler.java#L45-L67

Packet logs?

@iChun
Copy link
Contributor Author

iChun commented Mar 4, 2015

<Lex_> pig, imm -dfml.DebugHandshake=true i think.. i think that enables the packet logger i added...

@iChun
Copy link
Contributor Author

iChun commented Mar 4, 2015

For future reference it's debugNetworkHandshake.

@iChun
Copy link
Contributor Author

iChun commented Mar 4, 2015

Can't load a world if that's on. Console spits an error: https://gist.github.com/iChun/24a68f74f6d677382cb4

Game also hard locks if tried to quit from menu normally.

@LexManos
Copy link
Member

LexManos commented Mar 4, 2015

You're doing something to corrupt the packet format, thats whats causing the errors.
Give the EXACT code and EVERYTHING. Not the generic 'sendPacket' function as that tells me nothing about the packet being sent.

@iChun
Copy link
Contributor Author

iChun commented Mar 4, 2015

Considering it happens with no mods installed, I don't think it's me. Full FML Log. https://gist.github.com/iChun/ac145d246ec159beea7a

@cpw
Copy link
Contributor

cpw commented Mar 21, 2015

Did you try with the new debugging code? I believe lex fixed the debug issue causing a problem...

@iChun
Copy link
Contributor Author

iChun commented Mar 22, 2015

I've not tried it yet, have not had the time to be deving anything as of
late

On Sat, Mar 21, 2015 at 6:59 PM, cpw [email protected] wrote:

Did you try with the new debugging code? I believe lex fixed the debug
issue causing a problem...


Reply to this email directly or view it on GitHub
#608 (comment).

@iChun
Copy link
Contributor Author

iChun commented Mar 29, 2015

Trying to load a world with network debug still keeps you locked in the main menu (with no mods). Forge 1344. https://gist.github.com/iChun/f3135cf04261eb4972a0

@iChun
Copy link
Contributor Author

iChun commented Mar 29, 2015

This comes up when connected to a dedicated server instead. https://gist.github.com/iChun/1f7cb8afc1ba1c0db653

@iChun
Copy link
Contributor Author

iChun commented Mar 30, 2015

LexManos: point is to track the packet as far as possible. From what you've done sofar the error lies somewhere between the client's splitter and the server's send queue.add

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants